WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#14431 closed defect (bug) (fixed)

Password strength localization

Reported by: pavelevap Owned by: westi
Milestone: 3.0.1 Priority: normal
Severity: normal Version: 3.0
Component: I18N Keywords: has-patch
Focuses: Cc:

Description

Hi,

there is problem with localization of password strength statuses.

On profile page is used string "Medium" (with comment for translators)

'good' => _x('Medium', 'password strength')

but during installation there is used another string "Medium" (from Media Library)

good: "<?php echo esc_js( __( 'Medium' ) ); ?>"

and in our language there is different meaning. Please use unique string for both version of testing password strength...

Attachments (1)

t14331-medium-pass-strength-i18n.diff (606 bytes) - added by demetris 5 years ago.
Correct part of speech for “Medium” in Password Strength

Download all attachments as: .zip

Change History (7)

@demetris5 years ago

Correct part of speech for “Medium” in Password Strength

comment:1 @demetris5 years ago

  • Cc dkikizas@… added
  • Keywords has-patch added

Maybe this could go into 3.0.1, as it does not add new strings.

comment:2 @westi5 years ago

  • Milestone changed from Awaiting Review to 3.0.2
  • Version set to 3.0

This looks like a sane fix.

Good catch

comment:3 @westi5 years ago

  • Owner set to westi
  • Status changed from new to accepted

comment:4 @westi5 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

(In [15475]) Context for the medium password strength string to disabiguate it. Fixes #14431 for trunk props demetris.

comment:5 @westi5 years ago

  • Milestone changed from 3.0.2 to 3.0.1
  • Resolution fixed deleted
  • Status changed from closed to reopened

Sneaking

comment:6 @westi5 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [15476]) Context for the medium password strength string to disabiguate it. Fixes #14431 for 3.0.1 props demetris

Note: See TracTickets for help on using tickets.