WordPress.org

Make WordPress Core

Opened 10 years ago

Closed 8 years ago

Last modified 5 years ago

#1445 closed defect (bug) (fixed)

Add get_sidebar action

Reported by: janX Owned by: ryan
Milestone: 2.2 Priority: normal
Severity: normal Version: 1.5.2
Component: General Keywords: has-patch commit
Focuses: Cc:

Description

This is a proposal for new hooks that can be used to develop navigation plug-ins. I can supply an example if there is demand.

I propose to add the hooks template_header, template_footer and template_sidebar to template-functions-general.php.

Attachments (2)

template-functions-general.diff.txt (147 bytes) - added by janX 10 years ago.
diff to release version 1.5.1.2 of the file
1445.diff (399 bytes) - added by rob1n 8 years ago.

Download all attachments as: .zip

Change History (16)

@janX10 years ago

diff to release version 1.5.1.2 of the file

comment:1 @janX10 years ago

  • Keywords bg|has-patch bg|dev-feedback added
  • Severity changed from minor to normal
  • Summary changed from New hooks for navigation plug-ins to Add template_header, template_footer and template_sidebar action hooks [patch]
  • Version changed from 1.5.1.1 to 1.5.2

comment:2 @davidhouse10 years ago

Looks good.

comment:3 @skippy10 years ago

  • Keywords bg|squashed added
  • Owner changed from anonymous to skippy
  • Status changed from new to assigned

comment:4 @ryan10 years ago

  • Milestone changed from 2.0 to 2.1

comment:5 @janX10 years ago

Interesting. Is there a special reason for this to be moved to 2.1?

comment:6 @janX9 years ago

  • Milestone changed from 2.1 to 2.0.1

comment:7 @abhay9 years ago

probably because it's not a hook that's required to fix any bugs. 2.0.1 is supposed to be a bugfix release from 2.0

comment:8 @ryan9 years ago

  • Milestone changed from 2.0.1 to 2.1

Yep. We'll look at this for 2.1.

comment:9 @matt9 years ago

  • Milestone changed from 2.1 to 2.2

@rob1n8 years ago

comment:10 @rob1n8 years ago

  • Keywords has-patch commit added; bg|has-patch bg|dev-feedback navigation hooks bg|squashed removed
  • Owner changed from skippy to rob1n
  • Status changed from assigned to new

get_header() and get_footer() already had get_header and get_footer actions, the only one that was missing was get_sidebar, which my patch adds in.

comment:11 @rob1n8 years ago

  • Status changed from new to assigned

comment:12 @rob1n8 years ago

  • Summary changed from Add template_header, template_footer and template_sidebar action hooks [patch] to Add get_sidebar action

comment:13 @rob1n8 years ago

  • Owner changed from rob1n to ryan
  • Status changed from assigned to new

Reassigning to ryan to commit.

comment:14 @rob1n8 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [5136]) Add get_sidebar action to get_sidebar(). fixes #1445

Note: See TracTickets for help on using tickets.