WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 3 years ago

#14456 closed defect (bug) (fixed)

Check for valid $action in update-core.php

Reported by: ampt Owned by:
Milestone: 3.2 Priority: normal
Severity: minor Version:
Component: Upgrade/Install Keywords: has-patch 3.2-early
Focuses: Cc:

Description

Setting a non existent action param for update-core.php will cause just the footer of the admin to be displayed.

/wp-admin/update-core.php?action=test

The attached patch checks for a valid action and if one can't be found a redirect is issued.

Attachments (1)

14456.patch (632 bytes) - added by ampt 4 years ago.

Download all attachments as: .zip

Change History (6)

ampt4 years ago

comment:1 ampt3 years ago

  • Type changed from defect (bug) to enhancement

comment:2 ampt3 years ago

  • Type changed from enhancement to defect (bug)

comment:3 nacin3 years ago

  • Keywords 3.2-early added
  • Milestone changed from Awaiting Review to Future Release

Patch looks good.

comment:4 dd323 years ago

See Also: #15221

comment:5 dd323 years ago

  • Milestone changed from Future Release to 3.2
  • Resolution set to fixed
  • Status changed from new to closed

(In [17589]) Allow plugins to hook into /wp-admin/update-core.php. Props ampt. Fixes #15221

This effectively fixes this ticket too, the Footer is no longer shown on custom actions. Whilst a redirect is not offered, this gives it a good enough result.

Note: See TracTickets for help on using tickets.