wp_enqueue_script in_footer doesn't work on WP known scripts

[mcr2582]

I changed some plugin code from:
wp_enqueue_script('jquery-ui-sortable');

To:
wp_enqueue_script('jquery-ui-sortable',false,array(),false,true);

However, the script was not moved to the footer.

When I looked at the source for wp_enqueue_script, I can see that it's because the check for $in_footer is inside the condition for $src being defined. But built-in scripts don't require a source.

[nacin]

Don't think is_footer is the right check.

[mitchoyoshitaka]

I think is_footer is actually correct there. Would be nice to have this sorted out.

[SergeyBiryukov]

Simplified the patch a bit.

[MikeHansenMe]

tested and confirmed the patch works.

[valeriosza]

I think closing the valid ticket.

[wonderboymusic]

In 31028:

When calling wp_enqueue_script() with a registered $handle, no $src (using the default value, false), and true as the value for $in_footer, ensure that the script actually loads in the footer. If the handle was registered with $in_footer equal to true, this already worked. Make it work for scripts like where $in_footer was initially false, example: wp_enqueue_script( 'json2', false, array(), false, true );

Props SergeyBiryukov.
Fixes #14488.

[sc0ttkclark]

This introduces a change which now throws notices when $handle is an array. Of course, the wp_enqueue_script and wp_enqueue_style functions are not documented to accept arrays, they may be (and have been) used as such -- even by at least one of the most popular plugins on wordpress.org.

Up until earlier this month in the trunk commit for 4.2 [31028], the unintended consequences of calling the following code were that multiple handles could be enqueued at once. Documentation in code and in codex says it's a string, but it threw no notices or errors, or doing it wrong's.

wp_enqueue_script( array( 'jquery', 'etc', 'etc2' ) );

With that, should a new ticket be opened up to add documented support for array as $handle in wp_enqueue_script and wp_enqueue_style, or would this ticket need to have a new patch applied which at minimal removes the notice that's introduced in 4.2 for undocumented use of arrays?

[SergeyBiryukov]

Replying to sc0ttkclark:

This introduces a change which now throws notices when $handle is an array.

Related: #31636

[ocean90]

In 31887:

Avoid a PHP notice in wp_enqueue_script() if $handle is an array.

Calling wp_enqueue_script() with an array as the first argument is a "hidden feature" and should be avoided. Use dependencies instead.

props sorich87 for initial patch.
fixes #31636.
see #14488.