Make WordPress Core

Opened 14 years ago

Closed 11 years ago

#14501 closed enhancement (wontfix)

Add $taxonomy as 2nd parameter to 'edit_tag_form_fields' hook

Reported by: mikeschinkel's profile mikeschinkel Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.0
Component: Taxonomy Keywords: has-patch
Focuses: Cc:


Suggestion: Add $taxonomy as a 2nd parameter for the 'edit_tag_form_fields' hook in /wp-admin/edit-tag-form.php, line 67 in v3.0.1:


do_action('edit_tag_form_fields', $tag);

Change to:

do_action('edit_tag_form_fields', $tag, $taxonomy);

Ironically the taxonomy specific call (line 68) has the $taxonomy as a parameter:

do_action($taxonomy . '_edit_form_fields', $tag, $taxonomy);

And the "add" equivalents on lines 423+424 for /wp-admin/edit-tags.php have it too:

	do_action('add_tag_form_fields', $taxonomy);
do_action($taxonomy . '_add_form_fields', $taxonomy);

Change History (2)

#1 @dd32
13 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to Future Release
  • Version set to 3.0

You can get the taxonomy on this filter by using $tag->taxonomy, this would be why $taxonomy was not passed.

I dont see a need to add $taxonomy, But I dont see a reason not to add it; for consistency purposes, adding it seems like a potential good idea.

#2 @wonderboymusic
11 years ago

  • Milestone Future Release deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Hasn't been needed for at least 3 years

Note: See TracTickets for help on using tickets.