comment_notes_before does not work.

[hotforwords]

I am unable to get the comment_notes_before to work.

Using the code:

comment_form(array( 'comment_notes_before' => 'some text' ));

... does not work. it just leaves the default text there.

comment_form(array( 'comment_notes_after' => 'some text' ));

... does work. It allows you to put whatever text you want.

[mrmist]

move the comment notes before maybe

[mrmist]

I suspect what you're looking at is the logged in view, where comment_notes_before is not shown. However, since this is inconsistent with comment_notes_after, I've added a quick patch which just moves the before bit out of the if test.

There may be a desire to play about with where the field belongs, or debate over whether it should be shown for the logged in user, etc.. (I.E. Is it a bug or not?)

[yoavf]

+1 - the inconsistency with comment_notes_after is confusing and should be fixed

[beaulebens]

Patch makes sense to me -- positioning is inconsistent and doesn't make sense for likely use-cases of that text block.

[ryan]

[16649]

[westi]

This change breaks the display of the required fields text:

$required_text = sprintf( ' ' . __('Required fields are marked %s'), '<span class="required">*</span>' );

It is now shown whether or not the commenter is logged in rather than only for logged our commenters.

[westi]

All the core default comment_notes are for logged out users.

We probably need to add a new action for them if we are going to move this one.

Reverting for now

[westi]

(In [16704]) Revert [16649] - The core output on this is for logged out users only - need to rework this if we want to move the output. See #14510

[westi]

Example of what the change did to P2 while logged in

[nacin]

Punt?

[westi]

Replying to nacin:

Punt?

I think so - I'm not sure how to do this easily while keeping back compat on the current functionality.

We probably need a new arg rather than moving the current one.

[demetris]

Replying to westi:

Replying to nacin:

Punt?

I think so - I'm not sure how to do this easily while keeping back compat on the current functionality.

We probably need a new arg rather than moving the current one.

Maybe give a value to the arg only if the user is not logged in?

Attaching a tentative patch. I don’t like the ternary nesting very much, but that’s the only way I can think of that does not require an extra arg.

[demetris]

Moves comment_notes_before, and gives it value only if the user is not logged in

[nacin]

This isn't backwards compatible though. One man's broken comment_notes_before (as reported here) is another man's logged-out comment_notes_before.

[demetris]

I see.

But now I have another question. Does P2 use comment_form() in an optimal way? Why not do something like the following?

First:

function p2_comment_form_defaults($args)
{
    $args['comment_notes_after']    = '';
    $args['comment_notes_before']   = '<p>' . __('Blah blah') . '</p>';
    # Etc. etc.
        
    return $args;
}

Then:

add_filter('comment_form_defaults', 'p2_comment_form_defaults');

And then simply:

comment_form();

This is a genuine question, not a rhetorical one. :-)

[solarissmoke]

Related #16576

[chriscct7]

No forward movement in 5 years. Closing as maybe later. Feel free to reopen if someone wants to continue pursuing this.