WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 21 months ago

Last modified 21 months ago

#14531 closed defect (bug) (fixed)

Only show custom header preview when an image is set

Reported by: mtdewvirus Owned by: nacin
Milestone: 3.7 Priority: normal
Severity: normal Version: 3.0.1
Component: Customize Keywords: has-patch
Focuses: Cc:

Description

If a custom header is removed the preview shows an empty box. We should remove the Preview section in this case. Could also display a message "No header image set" or similar.

Attachments (2)

14531.diff (480 bytes) - added by mtdewvirus 5 years ago.
14531-2.diff (601 bytes) - added by nickmomrik 3 years ago.
Show the preview if a header image is set or header text is being displayed

Download all attachments as: .zip

Change History (8)

@mtdewvirus5 years ago

comment:1 @westi4 years ago

  • Keywords reporter-feedback added

This patch will hide the preview if no image is used but text is being displayed and a colour is in use which doesn't seem right.

@nickmomrik3 years ago

Show the preview if a header image is set or header text is being displayed

comment:2 @iseulde22 months ago

  • Keywords has-patch added; reporter-feedback removed

comment:3 @SergeyBiryukov21 months ago

  • Component changed from Themes to Appearance

comment:4 @nacin21 months ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 25135:

Only show 'Preview' on the custom header screen if there is something to show.

props nickmomrik.
fixes #14531.

comment:5 @SergeyBiryukov21 months ago

  • Milestone changed from Awaiting Review to 3.7

comment:6 @nacin21 months ago

Follow-up: #25156

Note: See TracTickets for help on using tickets.