WordPress.org
Get WordPress

Make WordPress Core

Opened 14 years ago

Closed 11 years ago

Last modified 11 years ago

#14531 closed defect (bug) (fixed)

Only show custom header preview when an image is set

Reported by: mtdewvirus's profile mtdewvirus Owned by: nacin's profile nacin
Milestone: 3.7 Priority: normal
Severity: normal Version: 3.0.1
Component: Customize Keywords: has-patch
Focuses: Cc:

Description

If a custom header is removed the preview shows an empty box. We should remove the Preview section in this case. Could also display a message "No header image set" or similar.

Attachments (2)

14531.diff​ (480 bytes) - added by mtdewvirus 14 years ago.
14531-2.diff​ (601 bytes) - added by nickmomrik 12 years ago.
Show the preview if a header image is set or header text is being displayed

Download all attachments as: .zip

Change History (8)

@mtdewvirus
14 years ago

#1 @westi
13 years ago

  • Keywords reporter-feedback added

This patch will hide the preview if no image is used but text is being displayed and a colour is in use which doesn't seem right.

@nickmomrik
12 years ago

Show the preview if a header image is set or header text is being displayed

#2 @iseulde
11 years ago

  • Keywords has-patch added; reporter-feedback removed

#3 @SergeyBiryukov
11 years ago

  • Component changed from Themes to Appearance

#4 @nacin
11 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 25135:

Only show 'Preview' on the custom header screen if there is something to show.

props nickmomrik.
fixes #14531.

#5 @SergeyBiryukov
11 years ago

  • Milestone changed from Awaiting Review to 3.7

#6 @nacin
11 years ago

Follow-up: #25156

Note: See TracTickets for help on using tickets.