Make WordPress Core

Context Navigation

← Previous Ticket
Next Ticket →

Opened 16 years ago

Closed 13 years ago

Last modified 13 years ago

#14531 closed defect (bug) (fixed)

Only show custom header preview when an image is set

Reported by:	mtdewvirus	Owned by:	nacin
Priority:	normal	Milestone:	3.7
Component:	Customize	Version:	3.0.1
Severity:	normal	Keywords:	has-patch
Cc:		Focuses:

Description

If a custom header is removed the preview shows an empty box. We should remove the Preview section in this case. Could also display a message "No header image set" or similar.

Attachments (2)

14531.diff (480 bytes ) - added by mtdewvirus 16 years ago.
14531-2.diff (601 bytes ) - added by nickmomrik 14 years ago.: Show the preview if a header image is set or header text is being displayed

Download all attachments as: .zip

Change History (8)

@mtdewvirus
16 years ago

Attachment 14531.diff added

#1 @westi
15 years ago

Keywords reporter-feedback added

This patch will hide the preview if no image is used but text is being displayed and a colour is in use which doesn't seem right.

@nickmomrik
14 years ago

Attachment 14531-2.diff added

Show the preview if a header image is set or header text is being displayed

#2 @iseulde
13 years ago

Keywords has-patch added; reporter-feedback removed

#3 @SergeyBiryukov
13 years ago

Component Themes → Appearance

#4 @nacin
13 years ago

Owner set to nacin
Resolution → fixed
Status new → closed

Only show 'Preview' on the custom header screen if there is something to show.

props nickmomrik.
fixes #14531.

#5 @SergeyBiryukov
13 years ago

Milestone Awaiting Review → 3.7

#6 @nacin
13 years ago

Follow-up: #25156

Note: See TracTickets for help on using tickets.

Download in other formats: