Flush Rewrite Rules on Submit, not on Page Load

[ikailo]

Current: Rewrite rules are flushed when /wp-admin/options-permalink.php is loaded.

Expected: Rewrite rules should be flushed only after the user submits the request.

Better Code

I see no reason to modify this behavior. It gets flushed on submit, too.

Forgive me, but I don't see the reasoning behind closing this ticket. The current state is inefficient.

When a user loads the page (clicks on Settings > Permalinks, nothing else), WordPress:

1. Makes unnecessary calls to the database to delete and insert the rewrite rules.
2. Makes unnecessary calls to the filesystem to rewrite the .htaccess file.

All without the explicit instruction of the user.

This can't possibly be expected behavior.

Replying to ikailo:

This can't possibly be expected behavior.

At least for the time being, it actually is. As you may (not) have noted, the rewrite rules aren't always refreshed properly, whether by WP or by themes or plugins. It's thus convenient, when supporting a user that has issues with pages not being found due to verbose rewrite rules and the like, to just tell him to visit his permalink settings in order to magically fix his site.