WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#14555 closed defect (bug) (fixed)

broken sprintf calls at multi site localization

Reported by: codestyling Owned by:
Milestone: 3.1 Priority: normal
Severity: critical Version: 3.0.1
Component: I18N Keywords: has-patch needs-testing gsoc
Focuses: Cc:

Description

The current version 3.0.1 contains this 2 places, where the brackets are not closed after the gettext phrase part and the surounded sprintf fails without having an argument that's why! Not sure, if this could be used to format anything from internal php stack stack into output!

file: wp-admin/ms-edit.php:211

wp_die( sprintf( __( 'You probably need to go back to the <a href="%s">sites page</a>', esc_url( admin_url( 'ms-sites.php' ) ) ) ) );

file: wp-admin/ms-edit.php:32

wp_die( sprintf( __( 'You probably need to go back to the <a href="%s">options page</a>.', esc_url( admin_url( 'ms-options.php' ) ) ) ) );

Attachments (2)

14555.diff (1.2 KB) - added by wojtek.szkutnik 5 years ago.
14555.2.diff (950 bytes) - added by sorich87 5 years ago.
refreshed patch

Download all attachments as: .zip

Change History (5)

comment:1 @wojtek.szkutnik5 years ago

  • Cc wojtek.szkutnik@… added
  • Keywords has-patch needs-testing gsoc added; bug removed

Not in ms-edit.php now, but still appears to be broken. This lil' patch should fix it.

@wojtek.szkutnik5 years ago

comment:2 @duck_5 years ago

  • Keywords gettext sprintf removed
  • Milestone changed from Awaiting Review to 3.1

@sorich875 years ago

refreshed patch

comment:3 @nacin5 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [16774]) Fix a sprintf call. props wojtek.szkutnik, sorich87. fixes #14555.

Note: See TracTickets for help on using tickets.