Make WordPress Core

Opened 14 years ago

Closed 14 years ago

#14582 closed enhancement (fixed)

Save/Publish spinners should be separate

Reported by: jane's profile jane Owned by: nacin's profile nacin
Milestone: 3.1 Priority: normal
Severity: minor Version: 3.0
Component: UI Keywords: needs-patch
Focuses: Cc:


When you click on Save Draft, the spinner is still located next to the Publish button, and there's no visual connection between the spinner and the action it is describing. Save Draft (on screens to add new post/page, in QuickPress, etc.) should have its own spinner to improve clarity.

Raised issue originally in related ticket, which fixed padding but not location:

User feedback reminding of the issue:

Attachments (2)

14582.2.diff (2.4 KB) - added by wojtek.szkutnik 14 years ago.
14582.diff (2.4 KB) - added by wojtek.szkutnik 14 years ago.

Download all attachments as: .zip

Change History (10)

#1 @nacin
14 years ago

+100. This trips me up all the time.

#2 @wojtek.szkutnik
14 years ago

  • Cc wojtek.szkutnik@… added
  • Keywords has-patch needs-testing gsoc added

introducing an additional spinner

#3 @JohnONolan
14 years ago

  • Keywords ux-feedback added
  • Owner set to JohnONolan
  • Status changed from new to reviewing

#4 @JohnONolan
14 years ago

Big +1 from me, looks great. Tested in Mozilla, Webkit, and IE. Screencast of patch in action here:[[BR]]

Suggest commit pending signoff from Jane.

#5 @JohnONolan
14 years ago

Damn BR tag, video here:

#6 @JohnONolan
14 years ago

On 2nd review I'd like to question why we need a new ID and inline styles add in this patch?

#7 @nacin
14 years ago

  • Keywords needs-patch added; has-patch needs-testing gsoc ux-feedback removed
  • Owner changed from JohnONolan to nacin
  • Status changed from reviewing to accepted

Let's move these to a class. The visibility bit should be the default in CSS as well, with JS then toggling it.

This keeps bugging me every time I save a post draft, so I'm likely going to just run with this.

#8 @JohnONolan
14 years ago

Do you mean move everything to a single class, eliminating both the multiple IDs and the inline CSS ? I'd support that.

One of the big problems with WP's CSS is that IDs are getting added in patches like this on a regular basis, bloat builds up over time with hundreds of single use IDs.

Hopefully with the CSS refactor we can make more smart/dynamic classes for use in multiple instances

#9 @nacin
14 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

(In [15722]) Use separate ajax spinners for the Save Draft and Publish buttons on the post form. fixes #14582 with initial patch from wojtek.szkutnik.

Note: See TracTickets for help on using tickets.