WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 6 years ago

Last modified 6 years ago

#14647 closed defect (bug) (fixed)

Missing .swf source files

Reported by: Derevko Owned by:
Milestone: 3.1 Priority: normal
Severity: normal Version: 3.0.1
Component: General Keywords:
Focuses: Cc:

Description

Hi,

sources for the following files are missing:

wp-includes/js/tinymce/plugins/media/img/flv_player.swf
wp-includes/js/swfupload/swfupload.swf

Cheers,
Giuseppe

Change History (16)

#1 @Derevko
7 years ago

  • Cc giuseppe@… added

#2 @Denis-de-Bernardy
7 years ago

  • Milestone changed from Awaiting Review to 3.0.2
  • Severity changed from major to blocker
  • Version set to 3.0.1

There also is the Easter bunny ticket that requests the source for the obfuscated code.

#3 @ramiy
7 years ago

  • Cc ramiy added

#4 @dd32
7 years ago

As this is an external library, Is it really needed to include the extra files in the WordPress svn? (In the context of the WordPress package, Ignoring Debian packaging rules)

The Source of the SwfUpload library is available in their code repository for example: http://swfupload.googlecode.com/svn/swfupload/trunk/core/ However I cannot find the source for the TinyMCE plugin.

Cross referencing the Debian bug report which has sparked this ticket: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=591195

#5 @sirono
7 years ago

TinyMCE source files can be found at github: https://github.com/tinymce
i don't think it is needed to include all the source files in the wordpress svn itself. as long as the external library's are used "as is" with no modifications to the source itself.

perhaps a simple solution would be to include a txt file with a link to the source code and/or website of this library?

#6 @nacin
7 years ago

  • Keywords 2nd-opinion close added
  • Milestone changed from 3.0.3 to Awaiting Review
  • Severity changed from blocker to normal

#7 @henrich
7 years ago

TinyMCE source files can be found at github

Yes, but flvplayer.swf doesn't have its source in there.

At http://oos.moxiecode.com/flvplayer/, there is no source and its license is as below

As long as you don´t try to profit from/sell it in any way, it´s probably fine.

And TinyMCE folks seem to not care about this so much
http://sourceforge.net/tracker/?func=detail&aid=3105324&group_id=103281&atid=635682

WordPress is distributed under GPL2, but you should mention about exception for flvplayer.swf

  • it's not OSS license at least.

#8 follow-up: @Derevko
7 years ago

  • Severity changed from normal to blocker

This should be a blocker.

According to http://tinymce.moxiecode.com/punbb/viewtopic.php?id=8223
this is likely to be flv_player.swf from <http://oos.moxiecode.com/flvplayer/>,
which does not come with source code, permission to distribute or any sort
of licensing information at all.

#9 in reply to: ↑ 8 @filosofo
7 years ago

Replying to Derevko:

This should be a blocker.

According to http://tinymce.moxiecode.com/punbb/viewtopic.php?id=8223
this is likely to be flv_player.swf from <http://oos.moxiecode.com/flvplayer/>,
which does not come with source code, permission to distribute or any sort
of licensing information at all.

At the bottom of http://oos.moxiecode.com/flvplayer/:

License (update: 2010-11-11)
I get a few questions about what kind of license this player is released under. I don´t know, really.
You can do pretty much whatever the hell you want with it as far as I´m concerned ;) So use it for whatever, redistribute it, etc.
As long as you don´t try to profit from/sell it in any way, it´s probably fine. If you are unsure, just drop me a quick email.

The last line is problematic for GPL-compatibility.

#10 @filosofo
7 years ago

Line breaks accidentally removed, so to clarify, I mean this line is problematic:

"As long as you don´t try to profit from/sell it in any way, it´s probably fine."

#11 @ryan
6 years ago

The media plugin is buried on the second button row for single site installs and not displayed at all for multisite. It really shouldn't even be shown to those who don't have unfiltered_html. We've discussed removing it entirely in the past. Let's go ahead and lose it.

#12 @nacin
6 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [17288]) Remove the TinyMCE media plugin. fixes #14647.

#13 @nacin
6 years ago

(In [17289]) Revert unrelated cruft in [17288]. see #14647.

#14 @nacin
6 years ago

  • Keywords 2nd-opinion close removed
  • Milestone changed from Awaiting Review to 3.1
  • Severity changed from blocker to normal

#15 @nacin
6 years ago

(In [17291]) Remove the button too. props ryan, see #14647.

#16 @hakre
6 years ago

Tag: FIXIPO

Note: See TracTickets for help on using tickets.