WordPress.org
Get WordPress

Make WordPress Core

Opened 21 years ago

Closed 21 years ago

#1465 closed defect (bug) (fixed)

Minor fix to _page_level_out()

Reported by: kapowaz's profile kapowaz Owned by: markjaquith's profile markjaquith
Milestone: Priority: low
Severity: minor Version: 1.5.1.2
Component: General Keywords: echo newline bg|has-post bg|commit
Focuses: Cc:

Description

Line 395 of /wp-includes/template-functions-post.php uses echo rather than concatenating to $output, despite the function taking an argument to either echo or return the output, meaning several newlines get echoed regardless.

Attachments (2)

template-functions-post.php​ (12.2 KB) - added by kapowaz 21 years ago.
Fixed version of _page_level_out() function
template-functions-post.php.diff​ (462 bytes) - added by markjaquith 21 years ago.
patch for 1.6 SVN

Download all attachments as: .zip

Change History (6)

@kapowaz
21 years ago

Fixed version of _page_level_out() function

@markjaquith
21 years ago

patch for 1.6 SVN

#1 @markjaquith
21 years ago

  • Keywords bg|has-post bg|commit added
  • Owner changed from anonymous to markjaquith
  • Status changed from new to assigned

Good catch. I uploaded a patch for the current code that is being worked on and am passing it along to the devs.

#2 @markjaquith
21 years ago

Credit should go to Tomw for this too, he reported it on June 19th: #1414

#3 @markjaquith
21 years ago

Bah, vroteus submitted it, Tomw provided a patch. ::rubs eyes::

#4 @matt
21 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [2686]) Output not echo, fixes #1465

Note: See TracTickets for help on using tickets.