#14657 closed enhancement (duplicate)
Resync Boolean Type Case
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | trivial | Version: | |
Component: | General | Keywords: | has-patch needs-refresh |
Focuses: | Cc: |
Description
TRUE to true and FALSE to false.
It seems patches weren't inline with the lowercase usage of the boolean type. Depends on programmer preference.
Attachments (1)
Change History (7)
#1
@
15 years ago
From what I remember, the use of the constants true
and false
should be lowercase. Patch looks good in that sense to me.
#2
@
15 years ago
Well, to me they should be lowercase because of having to type them out a lot. The other reason is that language reserve words or keywords should always be lowercase to differentiate from other user defined terms.
The argument is whether or not the language type lowercase usage should be used verses the language implementation of them actually being constants, albeit case-insensitive constants.
The problem also is that if we switch over to using what is defined as constants, we'll have to use NULL
instead of null
as well.
#3
@
15 years ago
- Keywords needs-refresh added; tested removed
- Milestone changed from Awaiting Review to Future Release
No way this patch still applies.
This patches a few external libraries. We shouldn't patch those, it becomes more difficult to merge in changes from upstream later on.
Change case of booleans in files.