WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 3 years ago

Last modified 3 years ago

#14727 closed defect (bug) (fixed)

@license tag removal in xmlrpc.php

Reported by: hakre Owned by:
Milestone: 3.1 Priority: normal
Severity: normal Version: 3.0.1
Component: General Keywords: has-patch
Focuses: Cc:

Description

File /xmlrpc.php is labeled as being GPL v2 licensed. This is incompatible to our license (broken).

The file/code as been labeled as "GPL v2" in [7991] 25 May 2008. It was not tagged with any specific license before that date.

The file was added in [1348] by michelvaldrighi (a projects developer) 23 May 2004. The code in //xmlrpc.php extends code of Third-Party-Code in the IXR Package that just had been added in [1346] shortly before.

The adding of the PHPdoc @license tag in [7991] / #7037 was wrong because of this: if the code is by a project contributor, it must have been under the projects license (naming GPL v2 here would break that so it can not be GPL v2) or it is considered a derivate of the added code (because it extends from it), but then it must have been under the same license as the IXR class which is currently known not to be GPL v2.

I'm just for reverting leaving all other considerations aside.

Attachments (1)

14727.patch (347 bytes) - added by hakre 4 years ago.

Download all attachments as: .zip

Change History (9)

hakre4 years ago

comment:1 hakre4 years ago

Related: #14726, #14685

comment:2 hakre4 years ago

Tag: FIXIPO

comment:3 jacobsantos4 years ago

Probably should. It might have been a test to see what it would look like in phpDocumentor without realizing that the implications of WordPress not actually being GPLv2 at the time.

comment:4 hakre4 years ago

Great feedback jacobsantos. That's very helpful.

comment:5 markjaquith4 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [15557]) This file was mistakenly labeled as being GPLv2-only. fixes #14727

comment:6 hakre4 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

props?

comment:7 Viper007Bond3 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

Re-closing.

Have a cookie, hakre.

comment:8 nacin3 years ago

  • Milestone changed from Awaiting Review to 3.1
Note: See TracTickets for help on using tickets.