WordPress.org

Make WordPress Core

Opened 9 years ago

Closed 9 years ago

#14731 closed defect (bug) (fixed)

wp-signup.php does not validate

Reported by: sorich87 Owned by: sorich87
Milestone: 3.1 Priority: normal
Severity: major Version: 3.0.1
Component: Validation Keywords: has-patch
Focuses: Cc:
PR Number:

Description

Line 89: end tag for element p which is not open.

The attached patch fixes the error.

Attachments (2)

14731.diff (669 bytes) - added by sorich87 9 years ago.
14731.2.diff (1.2 KB) - added by sorich87 9 years ago.

Download all attachments as: .zip

Change History (7)

@sorich87
9 years ago

#1 @nacin
9 years ago

  • Milestone changed from Awaiting Review to 3.1

The string shown in that patch is also broken...

#2 @sorich87
9 years ago

  • Cc sorich87@… added
  • Status changed from new to accepted

Broken? Here is the complete code:

	if ( !is_user_logged_in() ) {
		print '<p>(<strong>' . __( 'Your address will be ' );
		if ( !is_subdomain_install() )
			print $current_site->domain . $current_site->path . __( 'sitename' );
		else
			print __( 'domain.' ) . $site_domain . $current_site->path;
		echo '.</strong>) ' . __( 'Must be at least 4 characters, letters and numbers only. It cannot be changed, so choose carefully!' ) . '</p>';
	}

#3 @nacin
9 years ago

Right, the string is split up. Should be "Your address will be %s" with that value sprintf'd in.

@sorich87
9 years ago

#4 @sorich87
9 years ago

New patch... I hope there is no other thing I missed! :)

#5 @ryan
9 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

(In [16653]) Markup and gettext fixes. Props sorich87. fixes #14731

Note: See TracTickets for help on using tickets.