Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#14756 closed defect (bug) (fixed)

Bug adding users in multisite

Reported by: jane Owned by:
Milestone: 3.1 Priority: high
Severity: major Version: 3.1
Component: Network Admin Keywords: needs-ui
Focuses: multisite Cc:

Description (last modified by jane)

In 3.0 multisite (site in question is wordcamp.org), am having trouble adding new users to an individual site. When you click Add new User, you get:

You can add new users to your site in two ways:

1. Enter the username and email address of an existing user on this site.

2. Enter the username and the email address of a person who is not already a member of this site. Choose the username carefully, it cannot be changed.

That person will be sent an email asking them to click a link confirming the invite. New users will then be sent an email with a randomly generated password and a login link.

A) We should update that text to say network instead of site.

B) When I entered someone's username and email who was already in the network user system, instead of adding them to site, I get two error messages:
Sorry, that username already exists''

Sorry, that email address is already used''


Attachments (9)

create user.diff (508 bytes) - added by simonwheatley 5 years ago.
Amend one button's text from "Add User" to "Create User"
14756.diff (2.5 KB) - added by PeteMall 5 years ago.
14756.2.diff (2.5 KB) - added by PeteMall 5 years ago.
14756.3.diff (2.2 KB) - added by PeteMall 5 years ago.
14756.4.diff (913 bytes) - added by PeteMall 5 years ago.
14756.5.diff (1.1 KB) - added by PeteMall 5 years ago.
better-buttons.diff (1.6 KB) - added by westi 5 years ago.
Better Button Titles
better-buttons-take2.diff (1.6 KB) - added by westi 5 years ago.
Take 2, with proper user of context and consistency
better-buttons-take3.diff (1.6 KB) - added by westi 5 years ago.
Third time lucky?

Download all attachments as: .zip

Change History (27)

comment:1 @jane5 years ago

  • Description modified (diff)

comment:2 @duck_5 years ago

The network/site confusion was fixed in [15310].

Also, part B) works for me. Is it a specific user name/email combo or are all failing?

(Maybe the check in user-new.php lines 58/59 should use username_exists and email_exists like wpmu_validate_user_signup instead of the direct query)

comment:3 @simonwheatley5 years ago

  • Cc simon@… added
  • Keywords ux-feedback added
  • Version changed from 3.0 to 3.1

Part B also works for me, although I recommend we call the second button "Create User" for clarity. Attaching a minor patch create user.diff to do this.

Suggestion One: I wonder if the current screen couldn't be refactored though. Why do we need two areas? The more fields the more of a headache we're potentially causing users... could we have just one form and intelligently work out if we need to add or create and add the user.

Suggestion Two: If we want to keep the two form structure, then when someone mistakenly enters values in the "Create" section rather than the "Add" section should we (a) guess they want to add a user and just do it (assuming we have a user who matches both username and email), or should we add an error message with a button explaining that we think they meant to add a user, not create one, with these details and offering an "Add this user" button?

@simonwheatley5 years ago

Amend one button's text from "Add User" to "Create User"

comment:4 @ocean905 years ago

  • Milestone changed from Awaiting Review to 3.1

jane, any problems here still?

@PeteMall5 years ago


@PeteMall5 years ago


@PeteMall5 years ago

comment:5 @PeteMall5 years ago

(In [16930]) s/Creationism/Evolution/ in site-users. See #14756

@PeteMall5 years ago

comment:6 @westi5 years ago

We should use get_blog_option not raw SQL here in both cases.

Can probably move the setting of $default_role up to the top with $editblog_roles

@PeteMall5 years ago

comment:7 @PeteMall5 years ago

(In [16935]) Use get_blog_option() isntead of raw SQL in site-users. See #14756

comment:8 @PeteMall5 years ago

Leaving this open if someone wants to tweak the forms... See http://make.wordpress.org/ui/2010/12/14/203/.

Last edited 5 years ago by PeteMall (previous) (diff)

comment:9 @nacin5 years ago

  • Component changed from Multisite to Network Admin

comment:10 @JohnONolan5 years ago

  • Keywords needs-ui added; ux-feedback removed

comment:11 @ryan5 years ago

In the bug scrub, we discussed changing just the button text for 3.1 and pushing the more thorough rework to 3.2.

comment:12 @ryan5 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [17049]) Clarify button text. fixes #14756

comment:13 @ryan5 years ago

Modest string changes for 3.1. Further UI revamp pushed to 3.2. Accounting for being able to create and/or add users and the single site and multisite variations make this too big for 3.1.

comment:14 @westi5 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Should we not do this text clarification on the wp-admin/users.php page too as that always says Add New which is confusing when a user can only Add Existing.

comment:15 @nacin5 years ago

That's really trivial. "Add Existing" without "User" would look odd there I think. When they go to the page, it is clear that they're adding existing vs new. Close and revisit in 3.2?

@westi5 years ago

Better Button Titles

@westi5 years ago

Take 2, with proper user of context and consistency

comment:16 @westi5 years ago

That re-uses the strings in both places and makes the it clearer for users who can only promote that they are not entering some secret place they shouldn't go.

comment:17 @westi5 years ago

Seems I misinterpreted nacins feedback and got my consistency all wrong :-(

@westi5 years ago

Third time lucky?

comment:18 @westi5 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [17069]) Improve the button and header test to give a clearer picture between Adding New Users and Adding Exiting Users to a site. Fixes #14756

Note: See TracTickets for help on using tickets.