WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #14759


Ignore:
Timestamp:
09/01/2010 11:48:58 PM (9 years ago)
Author:
Viper007Bond
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #14759 – Description

    initial v1  
    11As Matt pointed to me today, caching oEmbed results to post meta is kinda lame.
    22
    3 I originally did this because I didn't want the HTML in old posts changing on it's own (say for example if the oEmbed provider got compromised). However I think that's extremely unlikely since we only whitelist major websites that can be trusted.
     3I originally did this because I didn't want the HTML in old posts changing on it's own, say for example if the oEmbed provider got compromised. However I think that's extremely unlikely since we only whitelist major websites that can be trusted.
    44
    5 Perhaps instead we should use transients to cache this data. That way when embed HTML is updated, posts will eventually be updated too.
     5Perhaps instead we should use transients to cache this data. That way when embed HTML is updated, posts will eventually be updated too due to expiring caches. I'm thinking a cache time of a week would be good, but with some random +/- to make sure multiple caches don't all expire at once.
    66
    77A good example of this is Vimeo. Anyone who embedded a Vimeo embed in their post before a few weeks ago got `<object>`-based embeds. However now Vimeo gives out `<iframe>` based ones. The only way currently to do this (without a few lines of code) is to edit all of the posts and re-save them to trigger a cache update. That's lame.