Make WordPress Core

Opened 14 years ago

Closed 10 years ago

#14791 closed enhancement (wontfix)

Twenty Ten Theme - Better Link Highlighting

Reported by: elfin's profile elfin Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords:
Focuses: Cc:

Description

mainly changing the state of text decoration(underline/none). This aids users that tab through links on a page identify where they are.

Attachments (1)

linkhighlighting.patch (2.6 KB) - added by elfin 14 years ago.

Download all attachments as: .zip

Change History (15)

#1 @elfin
14 years ago

ref previous ticket #14782

#2 @elfin
14 years ago

see also fixes for the gallery style #14792, may need to be applied at same time.

#3 @nacin
14 years ago

  • Keywords twentyten-a11y added

#4 follow-up: @iammattthomas
14 years ago

I like the highlighting additions, but not sure why we're removing the underline from some elements on hover and focus. It seems inconsistent; why not let all focused, active, and hovered links have an underline to reinforce the "linkiness" of the links.

#5 follow-ups: @iammattthomas
14 years ago

Also, -1 on losing the 10px border from gallery images. Adding a hover color can be a good idea, but we should use one that works with the larger border size -- it's a distinctive element in the design and I'd rather not lose it.

#6 in reply to: ↑ 5 @iammattthomas
14 years ago

Replying to iammattthomas:

Also, -1 on losing the 10px border from gallery images. Adding a hover color can be a good idea, but we should use one that works with the larger border size -- it's a distinctive element in the design and I'd rather not lose it.


(The other problem here is that to my color-blind eyes, a 1px border isn't enough for me to even see the highlight color without zooming in on the page.)

#7 in reply to: ↑ 4 ; follow-up: @elfin
14 years ago

Replying to iammattthomas:

I like the highlighting additions, but not sure why we're removing the underline from some elements on hover and focus. It seems inconsistent; why not let all focused, active, and hovered links have an underline to reinforce the "linkiness" of the links.

I was attempting to flip the state, ie if they had underlines they got removed, and vice versa.

#8 in reply to: ↑ 5 ; follow-up: @elfin
14 years ago

Replying to iammattthomas:

Also, -1 on losing the 10px border from gallery images. Adding a hover color can be a good idea, but we should use one that works with the larger border size -- it's a distinctive element in the design and I'd rather not lose it.

The 10px border - yeah to be honest I didn't think you'd like that change. It may need a separate color change, as the red was really ugly at that size.

I kept it to a 1px border on images to keep the change minimal, what width would you suggest for the standard (excluding special case like the gallery).

#9 in reply to: ↑ 7 @iammattthomas
14 years ago

Replying to elfin:

I was attempting to flip the state, ie if they had underlines they got removed, and vice versa.

Understood; I'd prefer to keep all links underlined on hover.

#10 in reply to: ↑ 8 @iammattthomas
14 years ago

Replying to elfin:

The 10px border - yeah to be honest I didn't think you'd like that change. It may need a separate color change, as the red was really ugly at that size.

I kept it to a 1px border on images to keep the change minimal, what width would you suggest for the standard (excluding special case like the gallery).

A fairly wide border, between 5-10px looks best in Twenty Ten. I'd not be opposed to a different color for images on hover since they're a special case -- but would let someone from the UI group chime in there since I'm color blind. :)

#11 @nacin
14 years ago

  • Milestone changed from Awaiting Review to Future Release

#12 @SergeyBiryukov
12 years ago

  • Component changed from Accessibility to Bundled Theme

#13 @SergeyBiryukov
12 years ago

  • Milestone changed from Future Release to WordPress.org

#14 @lancewillett
10 years ago

  • Keywords twentyten-a11y removed
  • Milestone WordPress.org deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Closing as we don't have plans to implement this 4-year-old Twenty Ten enhancement; we're focusing on improving and making newer themes.

Note: See TracTickets for help on using tickets.