Make WordPress Core

Opened 16 years ago

Closed 12 years ago

#14798 closed defect (bug) (wontfix)

Twenty Ten Theme - adding an extra skip link

Reported by: anonymized_3085 Owned by:
Priority: normal Milestone:
Component: Bundled Theme Version:
Severity: normal Keywords:
Cc: Focuses:

Description

Being able to skip to content is good, but currently there is no easy way to jump to the sidebar menu.

In order to add this extra skip (jump to menu) link I've changed the div to ul. CSS changes are similar to #14795 but tweaked to allow for the new markup.

Attachments (2)

too-tall-access.png (60.7 KB ) - added by iammattthomas 16 years ago.
extra-skip-link.patch (1.9 KB ) - added by anonymized_3085 16 years ago.

Download all attachments as: .zip

Change History (12)

#1 @nacin
16 years ago

  • Keywords twentyten-a11y added

#14782 parent ticket.

#2 @iammattthomas
16 years ago

I had to first apply the patch from #14795 to see this change, but having that patch in place made this patch fail to make changes to style.css. As a result I got a too-tall header: http://core.trac.wordpress.org/attachment/ticket/14798/too-tall-access.png

+1 to the idea, though; with the same caveat I made on #14795 about the skip links needing to be styled a bit more.

#3 @anonymized_3085
16 years ago

Can I check which browser you used?

I may have missed something when I split this down from the original patch.

#4 @iammattthomas
16 years ago

Sorry for the delay -- that'd be Safari 5.0.2/Mac.

#5 @anonymized_3085
16 years ago

Re-attached a patch. Downside is that it is adding one pixel to the height of the menu. A necessary evil to overcome an issue within webkit(Safari/Chrome).

Amended color to be a yellowish color to highlight the link even more.

#6 @iammattthomas
16 years ago

Font family and color should match the grey Helvetica/Arial/sans-serif menu links.

If you remove the bottom 1px border from #branding img, I think that would compensate for the extra 1px you've added here, so the design can remain the same. That'd be the best of both worlds.

#7 @iammattthomas
16 years ago

Thinking about it more, since the menu links are white on hover, white would make the most sense for the skip links, as they're focused when visible.

#8 @nacin
16 years ago

  • Keywords twenty-eleven added
  • Milestone Awaiting ReviewWordPress.org

#9 @SergeyBiryukov
14 years ago

  • Component AccessibilityBundled Theme

#10 @lancewillett
12 years ago

  • Keywords twentyten-a11y twenty-eleven removed
  • Milestone WordPress.org
  • Resolutionwontfix
  • Status newclosed

Closing as we don't have plans to implement this Twenty Ten enhancement; we're focusing on improving and making newer themes.

Note: See TracTickets for help on using tickets.