WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 5 weeks ago

#14798 closed defect (bug) (wontfix)

Twenty Ten Theme - adding an extra skip link

Reported by: elfin Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords:
Focuses: Cc:

Description

Being able to skip to content is good, but currently there is no easy way to jump to the sidebar menu.

In order to add this extra skip (jump to menu) link I've changed the div to ul. CSS changes are similar to #14795 but tweaked to allow for the new markup.

Attachments (2)

too-tall-access.png (60.7 KB) - added by iammattthomas 4 years ago.
extra-skip-link.patch (1.9 KB) - added by elfin 4 years ago.

Download all attachments as: .zip

Change History (12)

comment:1 nacin4 years ago

  • Keywords twentyten-a11y added

#14782 parent ticket.

comment:2 iammattthomas4 years ago

I had to first apply the patch from #14795 to see this change, but having that patch in place made this patch fail to make changes to style.css. As a result I got a too-tall header: http://core.trac.wordpress.org/attachment/ticket/14798/too-tall-access.png

+1 to the idea, though; with the same caveat I made on #14795 about the skip links needing to be styled a bit more.

comment:3 elfin4 years ago

Can I check which browser you used?

I may have missed something when I split this down from the original patch.

comment:4 iammattthomas4 years ago

Sorry for the delay -- that'd be Safari 5.0.2/Mac.

elfin4 years ago

comment:5 elfin4 years ago

Re-attached a patch. Downside is that it is adding one pixel to the height of the menu. A necessary evil to overcome an issue within webkit(Safari/Chrome).

Amended color to be a yellowish color to highlight the link even more.

comment:6 iammattthomas4 years ago

Font family and color should match the grey Helvetica/Arial/sans-serif menu links.

If you remove the bottom 1px border from #branding img, I think that would compensate for the extra 1px you've added here, so the design can remain the same. That'd be the best of both worlds.

comment:7 iammattthomas4 years ago

Thinking about it more, since the menu links are white on hover, white would make the most sense for the skip links, as they're focused when visible.

comment:8 nacin3 years ago

  • Keywords twenty-eleven added
  • Milestone changed from Awaiting Review to WordPress.org

comment:9 SergeyBiryukov21 months ago

  • Component changed from Accessibility to Bundled Theme

comment:10 lancewillett5 weeks ago

  • Keywords twentyten-a11y twenty-eleven removed
  • Milestone WordPress.org deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Closing as we don't have plans to implement this Twenty Ten enhancement; we're focusing on improving and making newer themes.

Note: See TracTickets for help on using tickets.