WordPress.org
Get WordPress

Make WordPress Core

Opened 16 years ago

Closed 15 years ago

#14816 closed defect (bug) (fixed)

Optimise dynamic_sidebar

Reported by: hakre Owned by:
Priority: normal Milestone: 3.2
Component: Widgets Version: 3.1
Severity: normal Keywords: has-patch 3.2-early commit
Cc: Focuses:

Description (last modified by westi)

Rasmus Lerdorf did some changes to Wordpress for a hphp compilation / performance presentation.

dynamic_sidebar can get out early if there are no sidebars.

Attachments (1)

14816-widgets.patch​ (509 bytes ) - added by hakre 16 years ago.
Shortcut.

Download all attachments as: .zip

Change History (7)

@hakre
16 years ago

Shortcut.

#1 @hakre
16 years ago

Full diff is here: ​http://progphp.com/wp/ (​More Info), dynamic_sidebar can get out early if there are no sidebars.

Just scanning and providing patches for the places I see fit but as I found later out:

Rest seems to be already fixed.

Last edited 15 years ago by hakre (previous) (diff)

#2 @hakre
16 years ago

And if not, probably already reported, like the constructor stuff from the presentation: #10861

#3 @hakre
16 years ago

Related: #14429
Related: [15639]
Related: [15637]
Related: [13684]

#4 @westi
16 years ago

  • Component General → Widgets
  • Description modified (diff)
  • Keywords has-patch 3.2-early commit added
  • Milestone Awaiting Review → Future Release
  • Summary Diverse Stuff from Rasmus Lerdorfs Patch → Optimise dynamic_sidebar
  • Version → 3.1

#5 @nacin
15 years ago

  • Milestone Future Release → 3.2

#6 @nacin
15 years ago

  • Resolution → fixed
  • Status new → closed

(In [17545]) Bail early in dynamic_sidebar() if there are no sidebars. fixes #14816.

Note: See TracTickets for help on using tickets.