get_theme_root/s refactoring

[hakre]

Some little work over the code while I ran over it.

[jane]

@hakre: Only the lead devs should change something to task (blessed), as it means it has been blessed by the leads.

[nacin]

Both of these changes make the code less readable.

(Not a task, at best an enhancement.)

[filosofo]

 	472	        while ( false === ( $theme_roots = get_site_transient( 'theme_roots' ) ) ) 
 	473	                get_themes(); // update transient 

Isn't this kinda risky? If something causes the transient getter or setter to fail, then you're stuck in an infinite loop.

[scribu]

I agree that this makes the code less readable. Cleverer code is not always better code.

[hakre]

Replying to filosofo:

 	472	        while ( false === ( $theme_roots = get_site_transient( 'theme_roots' ) ) ) 
 	473	                get_themes(); // update transient 

Isn't this kinda risky? If something causes the transient getter or setter to fail, then you're stuck in an infinite loop.

True, which would result in same: a failt of get_theme_roots() (as w/o the patch).

---

Replying to scribu:

I agree that this makes the code less readable. Cleverer code is not always better code.

Code is never clever.

Less code is better code.