Searching within comments filtered by post shows results from all comments

[mintindeed]

To reproduce:
Log in to WP admin
Go to "Comments"
Under "In response to" click the number of comments to filter comments by post
Search comments for any term
Search results show comments from all posts, not just the post being filtered

I've tested on versions 2.8.6, 2.9.2 and 3.0.1 and am able to reproduce on all.

It's arguable that the real bug is that "Comments on "Post name"" is still shown after searching, but if I've filtered comments by post and then search comments, I would expect to search through the comments I'm currently looking at.

[mintindeed]

screenshot showing unexpected search results in comments admin in WP v3.0.1

[nacin]

Sounds to me like we should remove the post query var, and don't allow searching within the post.

It's a UX issue beyond that point. We don't provide for searching within what is filtered anywhere else (I don't think).

[mintindeed]

Replying to nacin:

Sounds to me like we should remove the post query var, and don't allow searching within the post.

It's a UX issue beyond that point. We don't provide for searching within what is filtered anywhere else (I don't think).

I just checked in 3.0.1 -- when you are in Edit Posts and filter by category the search results are filtered by category. If you filter by tags or author, the search results are not filtered.

[mintindeed]

Comments search is global, so if this is a search remove the post id

[mintindeed]

After looking in trunk and checking out the new WP_List_Table class and ajax way of populating results, changing the way searhes are performed in 3.0.x would be unnecessary (and redundant).

I'm including a proposed patch for 3.0.1 that will remove the post ID when a search is performed, to get rid of the incorrect messaging.

[scribu]

Replying to nacin:

It's a UX issue beyond that point. We don't provide for searching within what is filtered anywhere else (I don't think).

With the new ajaxified version, filtered search should come naturally. Will look more into this when I get the chance.

[ryan]

Seems to be fixed by the new tables and comment search.