![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
#14856 closed enhancement (fixed)
Add an $args parameter to comment_text filter
| Reported by: | simonwheatley | Owned by: | wonderboymusic |
|---|---|---|---|
| Priority: | normal | Milestone: | 3.7 |
| Component: | Comments | Version: | |
| Severity: | normal | Keywords: | 3.2-early has-patch |
| Cc: | Focuses: |
Description
When using the comment_text filter, there are times when the context provided by $args would be extremely useful. For example to know the depth of the commen. I propose adding an additional parameter for comment_text to add the $args.
I've incorporated the proposed $comment_ID parameter from #14261, which looks to add a $comment_id parameter to the same filter, in the hope that this is helpful... let me know if not and I'll refactor.
I've included a small plugin to demo the use and prove the new parameters are working, and the diff for a small tweak to Twenty Ten v1.1 which is needed to use this plugin with that theme.
Attachments (9)
Change History (25)
#1
@
16 years ago
Related: #14681
some feedback:
- comment_text args param.diff contains a debug line: error_log( ... ).
- instead of passing $args (which looks okay to me so far, could not completely dig into there), another idea might be to pass the $comment object to the filter as well as it is done with posts.
#2
@
16 years ago
- Keywords 3.2-early added; needs-testing removed
- Milestone Awaiting Review → Future Release
Extra context for filters++;
#4
@
15 years ago
- Keywords needs-refresh added; needs-testing removed
I'm getting a "malformed patch" error.
#5
@
15 years ago
- Keywords needs-refresh removed
I refreshed the patch. It should apply cleanly now.
#6
@
15 years ago
Just a small thing: in function comment_text() the new args argument is not optional. And can you make $args default values array() instead of NULL for both functions?
#9
@
13 years ago
14856.2.diff fixes a typo in the Walker_Comment::comment() change and clarifies the docblock changes.
The passed args work as expected with the filters.
#13
in reply to: ↑ 12
@
13 years ago
Replying to wonderboymusic:
@DrewAPicture - please review this again
14856.3.diff refreshes the inline docs per standards and adds filter docs for the get_comment_text and comment_text filters.
#14
@
13 years ago
14856.4.diff adds defaults to the functional docs.
Small test plugin