streams.php, POMO_FileReader, binary read fopen, Windows

[cr00nad]

My system is :

Windows
PHP 4.3.0
Mysql 4.1

Minimal requiem for Wordpress.

In file: wp-includes/pomo/streams.php
Class: POMO_FileReader

Code:

function POMO_FileReader($filename) {

parent::POMO_Reader();
$this->_f = fopen($filename, 'r');

}

BUG (from PHP.net):
On systems which differentiate between binary and text files (i.e. Windows) the file must be opened with 'b' included in fopen() mode parameter.

FIX:

function POMO_FileReader($filename) {

parent::POMO_Reader();
$this->_f = fopen($filename, 'rb');

}

If you don't set 'rb' parametr in fopen languages files like mo are not loaded into system. Becouse incorrect read length
CLASS: POMO_Reader

function strlen($string) {

if ($this->is_overloaded) {

return mb_strlen($string, 'ascii');

} else {

return strlen($string);

}

}

And script stop on this line :
FILE: mo.php

$originals = $reader->read($originals_lengths_length);
if ( $reader->strlen( $originals ) != $originals_lengths_length )

return false;

--
cr00nad@…

[hakre]

Feedback seems reasonable to me. Maybe this is already fixed upstream in Pear?

[nbachiyski]

The change seems harmless, passes all tests, and was committed in ​http://trac.glotpress.org/changeset/597

[SergeyBiryukov]

Related: #14207

[scribu]

This is not a critical bug and it's not a regression from WP 3.0, so it can wait.

[ryan]

Fixed in [18528]