![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
Changes between Initial Version and Version 1 of Ticket #14889, comment 30
- Timestamp:
- 06/08/2011 04:39:46 PM (15 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #14889, comment 30
initial v1 179 179 }}} 180 180 181 What I see fis that not all functions have the admired scuccess rate. I tweaked map() to be conform, to be fair other functions might need some love as well.181 What I see is that not all functions have the admired success rate. I tweaked map() to be conform, to be fair other functions might need some love as well. 182 182 183 183 Using pow() looks expensive to me as well. 184 184 185 But what looks even more expensive to me (not shown in stats, but I tested for it) is the @ operator. If it is removed from the code speed will go significa lly up. I wonder if it is really needed for ini_get() / ini_set(). Perhaps warnings will scare a certain type of users away, because it will do warnings if those are disabled in `disable_functions`. If so, return will be `NULL`.Probably it's worth to cut short on NULL.185 But what looks even more expensive to me (not shown in stats, but I tested for it) is the @ operator. If it is removed from the code speed will go significantly up. I wonder if it is really needed for ini_get() / ini_set(). Perhaps warnings will scare a certain type of users away, because it will do warnings if those are disabled in `disable_functions`. If so, return will be `NULL`.Probably it's worth to cut short on NULL. 186 186 187 Functions with error/notices get a sligh penalty as the error callback gets called now. So if a function is giving notice or warning, it will not only fail but take longer.187 Functions with error/notices get a slight penalty as the error callback gets called now. So if a function is giving notice or warning, it will not only fail but take longer.
