WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #14889, comment 30


Ignore:
Timestamp:
06/08/11 16:39:46 (4 years ago)
Author:
hakre
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #14889, comment 30

    initial v1  
    179179}}} 
    180180 
    181 What I see fis that not all functions have the admired scuccess rate. I tweaked map() to be conform, to be fair other functions might need some love as well. 
     181What I see is that not all functions have the admired success rate. I tweaked map() to be conform, to be fair other functions might need some love as well. 
    182182 
    183183Using pow() looks expensive to me as well. 
    184184 
    185 But what looks even more expensive to me (not shown in stats, but I tested for it) is the @ operator. If it is removed from the code speed will go significally up. I wonder if it is really needed for ini_get() / ini_set(). Perhaps warnings will scare a certain type of users away, because it will do warnings if those are disabled in `disable_functions`. If so, return will be `NULL`.Probably it's worth to cut short on NULL. 
     185But what looks even more expensive to me (not shown in stats, but I tested for it) is the @ operator. If it is removed from the code speed will go significantly up. I wonder if it is really needed for ini_get() / ini_set(). Perhaps warnings will scare a certain type of users away, because it will do warnings if those are disabled in `disable_functions`. If so, return will be `NULL`.Probably it's worth to cut short on NULL. 
    186186 
    187 Functions with error/notices get a sligh penalty as the error callback gets called now. So if a function is giving notice or warning, it will not only fail but take longer. 
     187Functions with error/notices get a slight penalty as the error callback gets called now. So if a function is giving notice or warning, it will not only fail but take longer.