#14900 closed enhancement (fixed)
link-template string builder cleanup
| Reported by: | niallkennedy | Owned by: | wonderboymusic |
|---|---|---|---|
| Priority: | normal | Milestone: | 4.4 |
| Component: | General | Version: | |
| Severity: | normal | Keywords: | has-patch |
| Cc: | Focuses: | template |
Description
Convert dynamic strings to static strings where quick wins are available.
Wrap output such as translated strings in an esc_attr or esc_html just in case HTML can better handle what a parent page's character encoding can't.
Attachments (1)
Change History (9)
#1
@
16 years ago
- Component Permalinks → Template
Looks good to me so far. One thing of note is that I have the feeling the change of 'esc_url_raw' to 'esc_url' in the final patch chunk there may be wrong..
#2
@
16 years ago
- Milestone Awaiting Review → Future Release
Don't forget about the translation-enabled escaping functions, like esc_attr__()!
#7
@
11 years ago
Noting that r34444 broke the Edit links in Twenty Sixteen. https://github.com/WordPress/twentysixteen/issues/259
Had been using:
edit_post_link( sprintf( /* translators: %s: Name of current post */ __( 'Edit %s', 'twentysixteen' ), the_title( '<span class="screen-reader-text">', '</span>', false ) ), '<span class="edit-link">', '</span>'
Note:
See TracTickets
for help on using tickets.
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
staticize strings. escape some strings for HTML output.