WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 6 years ago

#14905 closed defect (bug) (fixed)

Plugin Search Term gets lost on Activation

Reported by: hakre Owned by:
Milestone: 3.1 Priority: normal
Severity: normal Version: 3.0
Component: Plugins Keywords:
Focuses: Cc:

Description

With Javascript Switched of on Trunk, searching for a plugin in the Backend does work.

But when such a search has been runned and a plugin of the serach result is being activated, after activation the plugin screen returns to a search result w/o searching for anything.

The search term is lost.

Expected result: The search term must be preserved with the request, not removed.

This problem exists in 3.0.1 (with a notice even) and 3.1-alpha.

Change History (8)

#1 @hakre
7 years ago

  • Component changed from General to Plugins

#2 @dd32
6 years ago

  • Milestone changed from Awaiting Review to 3.1

#3 @dd32
6 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [15697]) Preserve search terms on plugin management pages during actions. Fixes #14905 for trunk.

#4 @dd32
6 years ago

  • Milestone changed from 3.1 to 3.0.2
  • Resolution fixed deleted
  • Status changed from closed to reopened

re-opening for 3.0.x consideration

#5 @nacin
6 years ago

Patch as is will leave a lot of useless &s= scattered about. As long as that doesn't trigger any search conditions on account of it being empty though, I suppose that's fine.

#6 @dd32
6 years ago

Patch as is will leave a lot of useless &s= scattered about.

It does, But the paged variable was already basically useless in 95% of cases.. I personally don't mind there being a empty request variable set as long as they dont start a waterfall (ie. all the links on the page then include it, etc)

#7 @nacin
6 years ago

  • Milestone changed from 3.0.3 to 3.1

#8 @dd32
6 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

Marking as fixed.

Note: See TracTickets for help on using tickets.