author/user meta data extraction error

[iamronen]

It seems that if user meta data fields are created with dashes '-' then retrieval functions fail. Fields are properly stored in the database but retrieving with "get_the_author_meta" fails.

When I manually changed the field names to underscores '_' they were extracted OK. When I changes them back to dashes '-' they again failed.

[dd32]

using get_user_meta() works as expected.

The cause here is that the User object will store 'test-key' as 'testkey' due to dashes not being allowed in class properties thanks to this code: ​http://core.trac.wordpress.org/browser/trunk/wp-includes/user.php#L923

[iamronen]

I may be missing them - but the code you linked to seems to relate to basic user fields while I was referring to meta data (custom fields that I added) ... if it is as you say - it is an unclear and undocumented inconsistency. I would expect the two functions to behave identically.

[dd32]

Test Code:

update_user_meta(1, 'test-key', 'test');
var_dump( get_the_author_meta('test-key', 1) );
delete_user_meta(1, 'test-key');

Result Before:

string '' (length=0)

Result After:

string 'test' (length=4)

[dd32]

[15692] - Sanitize meta keynames used as object properties on retrieval. Fixes #14924