WordPress.org

Make WordPress Core

Opened 11 years ago

Closed 6 years ago

#14946 closed enhancement (maybelater)

Only enforce OEmbed whitelisting for dangerous types

Reported by: markjaquith Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.0
Component: Embeds Keywords: needs-patch
Focuses: Cc:

Description

Of the four OEmbed response types, only two (video and rich) are potentially dangerous. We should be able to allow all photo and link responses, without a whitelist.

Change History (6)

#1 @filosofo
11 years ago

I'm not sure that we can consider photo responses safe, in the sense that we use the value of the url parameter as the source for an image element.

In the past there have been security exploits (such as the GDI exploit) that used image files to trick clients into executing code.

Even the best-case scenario allows the remote server to set and read cookies.

#2 @jane
11 years ago

  • Keywords needs-patch dev-feedback added

@ryan, @westi, @azaozz, can you weigh in here? If this is going to get in, needs a patch asap to beat freeze. @filosofo's counter-argument sounds reasonable, though.

#3 @jane
11 years ago

  • Milestone changed from 3.1 to Future Release

No patch, and we're entering beta. Punting.

#4 @iseulde
8 years ago

  • Component changed from General to Embeds

#5 @chriscct7
6 years ago

  • Version changed from 3.0.1 to 3.0

#6 @johnbillion
6 years ago

  • Keywords dev-feedback removed
  • Milestone Future Release deleted
  • Resolution set to maybelater
  • Status changed from new to closed

No interest in five years.

Note: See TracTickets for help on using tickets.