Changes between Initial Version and Version 2 of Ticket #14955
- Timestamp:
- 09/24/2010 12:35:32 AM (14 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #14955 – Description
initial v2 3 3 From looking at /wp-admin/includes/plugin.php, adding support for uninstall is a separate concern (and it doesn't have the issue blocking activation/deactivation). 4 4 5 Should is_uninstallable_plugin, register_uninstall_hook and uninstall_plugin be extended to check theme directory or should versions (is_uninstallable_ plugin, register_uninstall_theme_hook and uninstall_plugin) be added to theme.php?5 Should is_uninstallable_plugin, register_uninstall_hook and uninstall_plugin be extended to check theme directory or should versions (is_uninstallable_theme, register_uninstall_theme_hook and uninstall_theme) be added to theme.php? 6 6 7 7 Advantage of the first method is that the register_uninstall_hook could be reused for Themes where in the second, a new, less attractive name would be needed (register_uninstall_theme_hook?) Also, there's no theme_basename as it was reverted/removed.