Nav-menu system does not always run titles through 'the_title' filter.

[Goldfrapper]

I am using the qTranslate plugin that uses the 'the_title' filter to parse its multilingual content (separated with comment tags). All titles are parsed well except for the titles appearing in the menu system's meta boxes; It seems this is because nav-menu functions don't run the titles through this filter.

[Denis-de-Bernardy]

Might they be using the widget_title filter or whatever that filter's name is? Seems more appropriate than the_title in this case, since the latter could end up outputting sifr.

[nacin]

the_title is used all over the admin as well, so no problem using it. Patch attached leverages the_title.

[wonderboymusic]

Refreshed against trunk, the old patch failed when applied

[nacin]

Looks like we can probably use get_the_title() here? Unsure, but we do use it elsewhere in this file.

Also, there is a $original_title = $original_object->post_title; assignment earlier in the file that could probably benefit from the same change.

[DrewAPicture]

get_the_title()

[DrewAPicture]

14975.3.diff​ uses get_the_title() instead per comment:6.

The filter via get_the_title() works as expected for me.

[DrewAPicture]

Should get_the_title() have been used on the post_type else as well?

[wonderboymusic]

In 25285:

Use get_the_title() when dealing with post_type-like items in the admin.

Props nacin, DrewAPicture.
Fixes #14975.