WordPress.org

Make WordPress Core

Opened 9 years ago

Closed 9 years ago

#14990 closed enhancement (worksforme)

Use CODE instead of KBD tag

Reported by: zeo Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: General Keywords: has-patch
Focuses: Cc:
PR Number:

Description

See patch.

Attachments (1)

14990.diff (2.6 KB) - added by zeo 9 years ago.

Download all attachments as: .zip

Change History (5)

@zeo
9 years ago

#2 @nacin
9 years ago

  • Keywords i18n-change removed

kbd is designed to be user input. I suppose we're probably inconsistent with this, but kbd seems semantic and proper here.

A footnote, i18n-change is only necessary for changes late in the development cycle (near or after string freeze) or for point releases, that way we can alert translators.

#3 @demetris
9 years ago

  • Cc dkikizas@… added

I agree with nacin. KBD is the correct semantic choice here.

CODE, on the other hand, is incorrect, not only here but in most other places it is used in the WP dashboard.

If the admin was HTML5, we could replace CODE in such instances with the repurposed I element (alternative voice or mood conventionally set in italic) and be done with it.

#4 @westi
9 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to worksforme
  • Status changed from new to closed

Closing.

Consensus is to stay with KBD here.

Note: See TracTickets for help on using tickets.