WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 3 years ago

Last modified 3 years ago

#14995 closed defect (bug) (fixed)

minor typing mistake results in ignoring parameters for the pack() function call

Reported by: jakub.misek Owned by:
Milestone: 3.1 Priority: normal
Severity: trivial Version: 3.1
Component: TinyMCE Keywords: has-patch
Focuses: Cc:

Description

/wp-includes/js/tinymce/plugins/spellchecker/classes/utils/JSON.php

line 535, 539, 543

wrong order of parenthesis and commas results in calling ord() function with more than 1 parameter.

Warning: ord() expects exactly 1 parameter, 2 given

Attachments (1)

14995.diff (1.5 KB) - added by duck_ 3 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 duck_3 years ago

This is an upstream bug in the Spellchecker plugin for TinyMCE with a PHP backend. Never the less, patch attached and I guess we should report to Moxiecode (quick search I couldn't find anything about this).

Problem is hard to come across since I believe it will only occur when the spellchecking service returns a result containing a UTF-8 character represented by either a 4, 5 or 6 byte sequence (aka uncommon ones).

duck_3 years ago

comment:2 duck_3 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 3.1

comment:3 nacin3 years ago

Sent a note to the TinyMCE guys.

comment:4 nacin3 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [16929]) Fix nesting of parentheses. fixes #14995, props duck_, jakub.misek.

comment:5 nacin3 years ago

Note came back from upstream, they'll be including it soon. Figured it was safe to go in here now.

Note: See TracTickets for help on using tickets.