Closing tag for empty <p> tag is removed

[miqrogroove]

I have a page post that starts like this:

<p style="text-align: right;">Text Here</p>
<p style="text-align: right;"></p>
More Text Here

The HTML source saves correctly, but the page output omits the closing tag for the second P element, causing the rest of the page to be invalid.

If you have any trouble reproducing this I will be happy to debug it on my server.

[miqrogroove]

The workaround I am currently using:

<p style="text-align: right;">Text Here</p>
<p style="text-align: right;">.</p>
More Text Here

Putting any text in the second paragraph somehow fixes the problem.

[scribu]

Confirmed.

[scribu]

Why do you need an empty <p> tag anyway?

[demetris]

Unsurprisingly perhaps, when I activated PHP Markdown (which automatically disables wpautop and does its own autoparagraphing) the problem disappeared.

[miqrogroove]

Why do you need an empty <p> tag anyway?

This ticket is about invalid output. If there's a problem in the html editor you should make a separate ticket for that.

[iseulde]

Tested in 3.6.

[iseulde]

Apologies, this is still a problem in 3.6.

[miqrogroove]

Indeed. Thank you for re-opening.

[c3mdigital]

In Trunk at r25093 The closing tag for the 2nd p element is not stripped.

<p style="text-align: right;">Text Here</p>
<p style="text-align: right;">
</p><p>More Text Here</p>

If I switch to visual editor the 2nd p element gets removed.

<p style="text-align: right;">Text Here</p>
<p>More Text Here</p>

[nacin]

Let's get a unit test here. Is this still reproducible in trunk, given TinyMCE 4.0? Is this particular to wpautop(), to JS's wpautop, to TinyMCE, what?

[codeclarified]

Confirmed that this is still happening in trunk and is due to wpautop(). Used the following as a quick test:

<p style="text-align: right;">Some Text</p>
<p style="text-align: right;"></p>
<p>Moar text</p>
<p></p>
<p class="some-class">Some text <a href="#something">with an anchor</a> and some more text</p>
<p>No attr, but a nested <a href="#">here</a></p>
<p>Let's try an empty nested tag: <a href="#test"></a></p>

Attaching a patch that updates the regex near line 424 to handle <p> tags that have attributes such as the text-align mentioned above. This left some orphan </p> tags, and balanceTags() looks like it handled that issue, although this probably needs to be tested a bit more thoroughly. With the content above, the empty <p> tags are completely removed, other tags are left as expected.

That said, this may also be a wontfix issue - in HTML5 it is perfectly valid to have <p> tags without a matching closing tag.

[codeclarified]

Updates to wpautop() regex

[jared_smith]

Unit test

[jared_smith]

I written a unit test in 15006-unit_test.patch​ which shows that 15006.diff​ causes more issues than it solves. That patch causes two additional unit tests to fail.

[ericlewis]

​This is why.