Deleting a category can orphan posts from the term_relationships table

[blepoxp]

Steps to reproduce:

1) Create a new category

2) Place a post in only that category

3) Delete that category

4) Observe that post no longer exists in term_relationship table (also causes posts to not appear in edit-posts list when filtered for 'uncategorized').

Cause of problem:
Direct calls to wp_delete_term() bypass logic and args previously populated in wp_delete_category().

Possible solutions:
Add logic from wp_delete_category() above each call for wp_delete_term and pass the args directly to wp_delete_term or conditionally check for taxonomy type and pass to wp_delete_category (a wrap for wp_delete_term) to pick up needed logic.

The attached diff takes approach two and passes to wp_delete_category if 'category' == $taxonomy

[blepoxp]

if taxonomy is category, send through wp_delete_category wrapper function

[nacin]

I think we should deprecate wp_delete_category() (also being used in XMLRPC) and move the logic into wp_delete_term().

[scribu]

Replying to nacin:

I think we should deprecate wp_delete_category() (also being used in XMLRPC) and move the logic into wp_delete_term().

+1

[blepoxp]

deprecates wp_delete_category

[blepoxp]

Updated diff deprecates wp_delete_category and places logic inside wp_delete_term.

[blepoxp]

remove (int) cast

[blepoxp]

Forgot xmlrpc function...

[dd32]

Can we abstract that functionality out of wp_delete_term() perhaps?

eg, An action fired within wp_delete_term() which has a functon hooked to manage the category weirdness's?

[nacin]

Replying to dd32:

Can we abstract that functionality out of wp_delete_term() perhaps?

eg, An action fired within wp_delete_term() which has a functon hooked to manage the category weirdness's?

That should probably be done across the board in #11576 for all CRUD actions, not just delete.

[nacin]

(In [15690]) Have wp_delete_category wrap wp_delete_term. Move wp_delete_category into wp-includes scope for consistency. fixes #15008, props blepoxp.

[nacin]

Decided there wasn't much harm in leaving the function as an undeprecated wrapper. We have quite a few of those in the taxonomy API for tag and category functions wrapping generic term functions.

[blepoxp]

Changeset looks like you deleted wp_delete_category w/o adding it back to deprecated.php or taxonomy.php. Am I reading that correctly?

[nacin]

(In [15712]) Restore wp_delete_category. props blepoxp, fixes #15008.