Filters / Actions for get_comments

[sc0ttkclark]

Currently in 3.1 (trunk) get_comments() has no filters or actions. I'd like to improve this by adding them following the same format as get_posts >> WP_Query::query uses. As you can see in my patch, it's very minimal, not too much going on here besides these main things:

1. New action pre_get_comments to run similar to WP_Query::query pre_get_posts

2. New filters / action for specific $post_where, $orderby, $oder, $limit (and some cache-enablers)

3. New filter the_comments to modify what's returned in $comments similar to WP_Query::query the_posts

[sc0ttkclark]

Initial Patch including the new filters / actions

[sc0ttkclark]

#1 is now a filter as per @nacin

[sc0ttkclark]

Just wanted to check in and see if there was anything further needed from me to get this into 3.1?

[scribu]

Do we really need the 'comments_orderby_request' series?

More importantly, note that the trend in WP_Query is to pass all query statements at once: #14997

[sc0ttkclark]

That was a straight copy / paste from another section, any idea what I should use as an example of the WP_Query for passing all query statements at once for filtering?

[scribu]

​http://core.trac.wordpress.org/browser/trunk/wp-includes/query.php?rev=15795#L2185

[sc0ttkclark]

Must have been working with a previous revision ;) Will adjust all corresponding patches.

[scribu]

Also, please try to make patches relative to the root WP folder. Currently, they are relative to wp-includes.

[sc0ttkclark]

Will do in the future, thanks for the best-practices update.

[sc0ttkclark]

Revised filters, after discussion with @scribu for best-practice methods

[sc0ttkclark]

Refreshed and revised after IRC discussion with @scribu for best-practice methods.

[sc0ttkclark]

Patch refreshed and revised with adjustments to the changes made by refresh - also fixed $post_where to be $where (for consistency) and resolved a bug with $author_email / $karma not adding a space before the AND in appending $where

[sc0ttkclark]

Attached new patch - Patch refreshed and revised with adjustments to the changes made by refresh - also fixed $post_where to be $where (for consistency) and resolved a bug with $author_email / $karma not adding a space before the AND in appending $where

[sc0ttkclark]

Revised to use do_action_ref_array vs apply_filters_ref_array

[scribu]

(In [16019]) Add filters to WP_Comment_Query. Props sc0ttkclark. Fixes #15019

[scribu]

(In [16020]) Make comment clauses more similar to post clauses. See #15019