#1502 closed defect (bug) (fixed)
Themes and Plugins pages don't check to see if file is readable
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Milestone: | Priority: | normal | |
| Severity: | normal | Version: | 1.6 |
| Component: | Administration | Keywords: | bg|has-patch|needs review |
| Focuses: | Cc: |
Description
Neither the themes or plugin information grabbing code use is_readable() before trying to open a file. This occurs in multiple places in admin-functions.php and can cause errors for files that are not readable by the webserver. I'll submit a patch tomorrow, unless someone beats me to it.
Note: This is not a dupe of #1370 , it points out problems beyond what's listed there.
Attachments (1)
Change History (5)
#2
@
20 years ago
- Keywords bg|has-patch|needs review added; bg|needs-patch removed
I've attached a patch file to resolve this issue. It adds in the is_readable check for both theme files and plugin files.
The theme file check adds a message to the broken_themes array.
Note: See
TracTickets for help on using
tickets.
Patch file to resolve this issue