Make WordPress Core

Opened 21 years ago

Closed 20 years ago

Last modified 19 years ago

#1502 closed defect (bug) (fixed)

Themes and Plugins pages don't check to see if file is readable

Reported by: masquerade's profile masquerade Owned by:
Milestone: Priority: normal
Severity: normal Version: 1.6
Component: Administration Keywords: bg|has-patch|needs review
Focuses: Cc:

Description

Neither the themes or plugin information grabbing code use is_readable() before trying to open a file. This occurs in multiple places in admin-functions.php and can cause errors for files that are not readable by the webserver. I'll submit a patch tomorrow, unless someone beats me to it.

Note: This is not a dupe of #1370 , it points out problems beyond what's listed there.

Attachments (1)

ticket-1502-patch.diff (6.6 KB) - added by MikeLittle 20 years ago.
Patch file to resolve this issue

Download all attachments as: .zip

Change History (5)

#1 @markjaquith
21 years ago

  • Keywords bg|needs-patch added
  • Milestone changed from 1.5.1 to 1.6

@MikeLittle
20 years ago

Patch file to resolve this issue

#2 @MikeLittle
20 years ago

  • Keywords bg|has-patch|needs review added; bg|needs-patch removed

I've attached a patch file to resolve this issue. It adds in the is_readable check for both theme files and plugin files.
The theme file check adds a message to the broken_themes array.

#3 @ryan
20 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [3103]) Make sure plugins and themes are readable. Props Mike Little. fixes #1502

#4 @(none)
19 years ago

  • Milestone 2.0 deleted

Milestone 2.0 deleted

Note: See TracTickets for help on using tickets.