Opened 14 years ago
Closed 10 years ago
#15029 closed defect (bug) (fixed)
Make it possible to determine resource in get_ancestors()
Reported by: | filosofo | Owned by: | boonebgorges |
---|---|---|---|
Milestone: | 4.1 | Priority: | normal |
Severity: | normal | Version: | 3.1 |
Component: | Taxonomy | Keywords: | has-patch |
Focuses: | Cc: |
Description
In case there exists a conflict between taxonomy and post_type names, allow it to be resolved explicitly when calling get_ancestors()
.
Attachments (4)
Change History (16)
#4
@
14 years ago
I think we should prevent conflicts between post_type and taxonomy names at the registration step, not later.
#5
@
14 years ago
On second thought, nevermind. I was thinking about query_var, which doesn't have to corespond to the taxonomy name.
#6
follow-up:
↓ 7
@
14 years ago
By the way, shouldn't we also check if the post type is hierarchical, like we do for taxonomies?
#7
in reply to:
↑ 6
@
14 years ago
Replying to scribu:
By the way, shouldn't we also check if the post type is hierarchical, like we do for taxonomies?
Agreed; I don't think is_post_type_hierarchical
existed when I wrote the original patch.
I also agree that checking query_var and maybe rewrite slug are good ideas.
#11
@
10 years ago
- Keywords needs-refresh removed
- Milestone changed from Future Release to 4.1
- Owner changed from filosofo to boonebgorges
- Status changed from new to accepted
15029.patch refreshes the patch for the modern age.
Please ignore the first patch with its logic flaw.