upgrade.php "have fun" link to blog is blank

[ryanduff]

upgrade php uses get_settings('home') instead of get_settings('url') to generate the link back to the main page. Home is currently an empty variable.

Patch attached.

[ryanduff]

Summary should read "instead of get_settings('siteurl')" not "instead of get_settings('url')". Patch was correct, typo in summary on my part

[ryan]

siteurl is not the proper place to send someone. home should not be empty. That is what needs to be fixed.

[ringmaster]

This sets 'home' to a guess at the blog URL.

[ringmaster]

Some clarification on the purpose of options in general, and 'home' vs. 'siteurl' in specific might be useful.

I noticed that a lot of the 'siteurl' option requests had changed to 'home' in this latest patch. Plugin authors would do good to be aware of potential resulting changes to their code - I am known to have used 'siteurl' quite often.

[markjaquith]

$guesurl isn't necessarily right... it points to the wordpress directory, which is what it did for 1.5.x

[ryanduff]

#1596 was marked a duplicate of this

[markjaquith]

for WP 1.6 SVN (should have a trailing slash on the URI)

[markjaquith]

for WP 1.6 SVN (adds 'home' on install, and on upgrade (if blank))

[markjaquith]

Okay. Uploaded two patches.

The upgrade.php one adds a trailing slash to the URI given. Small thing, I know... but might as well, while we're at it.

The upgrade-schema.php patch keeps ringmaster's fix to add a 'home' value on install, but also has a line to add it if it is blank (for the upgrade). The problem was that add_option() doesn't do anything if the option already exists. So my patch checks to see if it is blank, and updates it if it is. Tested, and works.

Marking this for commit.

[ryan]

(In [2817]) Set home during install. Props Owen and Mark. fixes #1506

[(none)]

Milestone 2.0 deleted