WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 3 years ago

#15133 closed enhancement (maybelater)

Add oEmbed support for deviantART

Reported by: PotterSys Owned by:
Milestone: Priority: normal
Severity: minor Version: 3.1
Component: Embeds Keywords: deviantart, oembed, has-patch
Focuses: Cc:

Description

Today, deviantART added oEmbed support; so it can be added to the core oEmbed provider list.

I added the parameters to the oEmbed default providers, and it works. However, the deviantART oEmbed returns the original image data and the thumbnail. As original images by dA are usually big (you can find original images > 20 MB), I chose to return the thumbnail information if the thumbnail_url value is not empty.

Don't be afraid to change the (crappy) regexps; and possible solutions to the "thumb or no thumb" dilemma

Attachments (1)

dA_oembed.patch (1.7 KB) - added by PotterSys 4 years ago.
First patch attempt

Download all attachments as: .zip

Change History (4)

PotterSys4 years ago

First patch attempt

comment:1 scribu4 years ago

I think it was agreed we won't be adding any more oEmbed providers to Core, since it's so easy to add them from a plugin or theme.

Maybe you'd be intersted in taking over the Deviant Thumbs plugin instead?

http://scribu.net/wordpress/deviant-thumbs/developer-wanted.html

comment:2 PotterSys4 years ago

  • Keywords has-patch added
  • Severity changed from normal to minor

I know it's not the idea to have hundreds of sites on the provider list, but 2 new sites were added for oEmbed on 3.0; and dA could be at least interesting to have.

And about the plug-in, I'll think about; thanks for the tip.

comment:3 westi3 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to maybelater
  • Status changed from new to closed

This is best in a plugin for now

Note: See TracTickets for help on using tickets.