When non-hierarchical CPT permalinks change, we should 301 redirect like with posts

[scribu]

I've been trying to find the code that does that, but I guess I haven't been trying hard enough.

+1 from me.

[nacin]

I've been meaning to create this ticket for about two weeks.

[Denis-de-Bernardy]

#9825

[nacin]

The scope for this ticket is much narrower.

I will post a patch.

[Denis-de-Bernardy]

Replying to nacin:

The scope for this ticket is much narrower.

I beg to differ. If you implement it for the previous URL without bugs (I.e. deleting conflicts as they appear), implementing it for all URLs is a matter of using multiple key/values instead of a single one.

[dd32]

I've been trying to find the code that does that, but I guess I haven't been trying hard enough.

Probably be looking for ​wp_old_slug_redirect() ..That really should be merged with Canonical IMO..

[dd32]

(In [15831]) Save _wp_old_slug for all published post_type's, brings old-slug redirection to Posts and CPT's. See #15140

[dd32]

(In [15832]) Use $wpdb->prepare in wp_old_slug_redirect(). See #15140

[dd32]

I realised this morning, That I didn't limit the redirection to posts of the same post type as being requested..

Potential thoughts of mine:

• Request ALL matching records, foreach ($post ) { if ( compare post type ) { redirect;break; } }
• JOIN in SQL, seems overkill.

[dd32]

(In [15848]) Limit wp_old_slug_redirect() to redirecting to only posts of the same post_type kind. See #15140

[dd32]

Closing as fixed, Re-open if a bug related to this crops up in 3.1 testing, Else, open a new ticket.

[Denis-de-Bernardy]

Let's implement #9825 step/bug by step/bug...

If both the slug and the parent change, the redirect doesn't work.

[Denis-de-Bernardy]

Oh, forgot to mention. You then need to create a new page, different parent, same slug, to fully appreciate why we need to store/flush the actual permalink, rather than just the slug.

[nacin]

#9825 should stay in #9825. However, handling only the slug for hierarchical post types isn't a very good idea, I agree. Per discussion in IRC, this should be limited to non-hierarchical post types only for now.

[markjaquith]

Denis' objection is noted. I don't think this is ready for hierarchical post types. I'm working on a patch to restrict this to non-hierarchical post types for now, and we can look at a hierarchical fix for 3.2

[automattor]

(In [16818]) Do not do slug logging/redirects for hierarchical post types. see #15140

[markjaquith]

(In [16819]) Use is_page_type_hierarchical(). props nacin. see #15140

[dd32]

Closing as fixed in 3.1 for non-hierarchical post types, For Pages, We have #4328 still

[nacin]

​http://core.trac.wordpress.org/changeset/16818/trunk/wp-includes/query.php broke a trick I've leveraged where I stuffed _wp_old_slug into the DB for a page, and then the redirect took place. Very few have likely done that, but it's technically a regression.