WordPress.org

Make WordPress Core

Changes between Version 3 and Version 4 of Ticket #15155, comment 8


Ignore:
Timestamp:
07/02/11 05:31:33 (3 years ago)
Author:
djr
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #15155, comment 8

    v3 v4  
    33  My approach presumes that if the user is excluding at least one image, they will know enough to be able to exclude the post thumbnail as well. And if for some reason they'd like to include the post thumbnail image as part of the gallery, they can still do so. 
    44 
    5 Food for thought: not all images are explicitly excluded. Some, like post_thumbnail, are automatically attached, e.g. by plugins like Regenerate Thumbnails (not sure) or Auto Post Thumbnail (the one we're using). See [http://wordpress.org/support/topic/plugin-auto-post-thumbnail-featured-image-attachment-url-causes-gallery-issues this forum post] for a scenario where this patch wouldn't help. I'd really love to see an explicit 'use_post_thumbnail' [Yes/No] filter for the gallery shortcode. 
     5Food for thought: not all images are explicitly excluded. Some, like post_thumbnail, are automatically attached after publish_post has fired, e.g. by plugins like Regenerate Thumbnails (not sure) or Auto Post Thumbnail (the one we're using). See [http://wordpress.org/support/topic/plugin-auto-post-thumbnail-featured-image-attachment-url-causes-gallery-issues this forum post] for a scenario where this patch wouldn't help. I'd really love to see an explicit 'use_post_thumbnail' [Yes/No] filter for the gallery shortcode.