WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#15174 closed enhancement (fixed)

Move edit blog page to dedicated files

Reported by: ryan Owned by:
Milestone: 3.1 Priority: normal
Severity: normal Version: 3.1
Component: Multisite Keywords: ongoing-project
Focuses: Cc:

Description (last modified by ryan)

The edit blog form is currently accessed via /network/sites.php?action=editblog&id=1. Accessing the form via sites.php confuses screen options and other UI elements. The form should be accessed via edit.php instead. In general, the blog edit code in the network admin needs a refactor.

  • Move edit.php to site.php
  • Access the blog edit form via site.php?action=edit
  • Put the form in edit-blog-form.php
  • Use proper meta boxes and screen options for the form, using edit-form-advanced.php as inspiration
  • Put meta box call back functions in network/meta-boxes.php ( or wp-admin/includes/network-meta-boxes.php)

Attachments (5)

15174.diff (305 bytes) - added by markmcwilliams 4 years ago.
missing @since in site-new.php
edit-site.png (102.9 KB) - added by ryan 4 years ago.
Screenshot of tab proposal
edit-site-2.png (102.5 KB) - added by ryan 4 years ago.
Move tabs below h2 into an h3.
15174.2.diff (2.0 KB) - added by PeteMall 4 years ago.
Use correct screen icon.
15174.3.diff (403 bytes) - added by PeteMall 4 years ago.
Missed the screen icon on site-new

Download all attachments as: .zip

Change History (27)

comment:1 @ryan4 years ago

  • Description modified (diff)

comment:2 @ryan4 years ago

  • Description modified (diff)

comment:3 @ryan4 years ago

Alternative: instead of piling huge boxes into one page, move Info, Options, Users, Themes, etc. into separate pages with their own top-level tabs.

comment:4 @ryan4 years ago

  • Keywords ux-feedback added

comment:5 @jane4 years ago

  • Keywords ux-feedback removed

I'd be up for trying tabs. UI group still struggling with a decent tab style as per themes screen, so if you want to throw something in and commit so we can test it a little and then revise, that would be good.

comment:6 @automattor4 years ago

(In [15886]) Move add site form to site-new.php. see #15174

@markmcwilliams4 years ago

missing @since in site-new.php

comment:7 follow-up: @markmcwilliams4 years ago

Mind the @since for site-new.php in [15886] you forgot!

comment:8 in reply to: ↑ 7 ; follow-up: @nacin4 years ago

Replying to markmcwilliams:

Mind the @since for site-new.php in [15886] you forgot!

Make sure you diff from the root, that way paths are complete. Otherwise it forces me to type in the location of site-new.php. Or worse, it could be something like post.php, for which there are three.

comment:9 @nacin4 years ago

(In [15895]) Add @since to new file. props markmcwilliams. see #15174.

@ryan4 years ago

Screenshot of tab proposal

comment:10 in reply to: ↑ 8 @markmcwilliams4 years ago

Replying to nacin:

Replying to markmcwilliams:

Mind the @since for site-new.php in [15886] you forgot!

Make sure you diff from the root, that way paths are complete. Otherwise it forces me to type in the location of site-new.php. Or worse, it could be something like post.php, for which there are three.

Ah crap (newbie error), I forgot about that, sorry Andrew! :(

The layout looks good to me Ryan! +1

@ryan4 years ago

Move tabs below h2 into an h3.

@PeteMall4 years ago

Use correct screen icon.

comment:11 follow-up: @scribu4 years ago

Why is the site domain and path not editable anymore?

comment:12 in reply to: ↑ 11 ; follow-up: @nacin4 years ago

Replying to scribu:

Why is the site domain and path not editable anymore?

That's for the main site only.

comment:13 @nacin4 years ago

[15903] from Ryan.

comment:14 in reply to: ↑ 12 @scribu4 years ago

Replying to nacin:

Replying to scribu:

Why is the site domain and path not editable anymore?

That's for the main site only.

Indeed. Liking the new layout.

comment:15 @nacin4 years ago

(In [15907]) Use correct network admin icon. props PeteMall, see #15174.

@PeteMall4 years ago

Missed the screen icon on site-new

comment:16 @nacin4 years ago

(In [15908]) And site-new, too. props PeteMall, see #15174.

comment:17 @jane4 years ago

  • Keywords ongoing-project added
  • Type changed from defect (bug) to enhancement

comment:18 @ryan4 years ago

(In [16014]) Action switch no longer needed. see #15174

comment:19 @westi4 years ago

(In [16126]) Correct the subdomain/non-subdomain logic when listing sites.
Tidy up the case statement.
See #15174.

comment:20 follow-up: @ocean904 years ago

[16126] brokes the names for me. http://grab.by/7c0H (Subdomain install)

comment:21 in reply to: ↑ 20 @markmcwilliams4 years ago

Replying to ocean90: With #15297 that was fixed in [16158] not long ago!

comment:22 @ryan4 years ago

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.