JavaScript Validation should trim values and set focus on invalid field

[batmoo]

If invalid fields are found after validation, focus should be placed on the first invalid field. Field values should be trimmed to check for truly empty values.

Also worth noting, the (mostly same) validateForm is located in both common.js and wpAjax.js.

[batmoo]

Patch removes redundant validateForm from common.dev.js and uses the one in wp-ajax-response.js (though, in retrospect, it may be better to move it to a more agnostic place so that non-ajax submits can make use of it too).

Patch trims field values and sets focus on the first invalid field.

[nacin]

common will probably be enqueued in more places than wp-ajax-response. I imagine it may have been intentional for both to exist.

[batmoo]

As far as I can tell, the only place that validateForm is in use is on tags.dev.js. Even then, it's redundant as almost all of the JS validation on the site is being handled by wp-ajax-response.

Regardless, new patch restores validateForm on common.dev.js, adds trim and focusing, and I've added some indentation to the functions to make them a bit more readable :)

[bassgang]

@batmoo can you provide more context to your description where the validation exactly happens?
Furthermore I doubt that the ticket still is a "defect (bug)", would not be "enhancement" as ticket type more appropriate?

[nacin]

This JS is still really dense; I'm not positive it's all fine and dandy, and given it's been three years, I doubt batmoo would know either. :-( Moving to Future, would be nice to fix this of course. Sorry for having delayed it three years ago.