wp_count_comments throws Error Notice for unknown comment_approved types

[batmoo]

If you have any comments with a comment_approved value of an "unknown type" (i.e. anything other than '0' => 'moderated', '1' => 'approved', 'spam' => 'spam', 'trash' => 'trash', 'post-trashed' => 'post-trashed'), wp_count_comments throws an error notice.

Notice: Undefined index: 'my-custom-approved' in /Users/moo/Sites/dev/WordPress/wp-includes/comment.php on line 858

Setting the in_array check to strict, fixes the error.

[batmoo]

Patch sets in_array check on wp_count_comments to strict.

[markjaquith]

Would really be nice to have full support for custom comment statuses. You can't really do it properly now.

[hakre]

+1 Patch looks good in my eyes, strict check is reasonable. Everything else can be done in an additional ticket if there really is a want for it.

[tfnab]

Alternative way of fixing this; patch for 3.1 which has the same issue

[tfnab]

+1
Please re-consider fixing this ASAP, i.e. before 3.2, but maybe with another minor version number release, as this has me changing core to avoid the notices thrown, and it makes the update process much more annoying (but I want to stay updated in case of any security issues)!

Thank you.

I've added another patch that removes the unneccessary $known_types variable

[nacin]

Notices aren't enough for point releases. Especially for API usage that is technically unsupported.

[ryan]

In [17795]:

Fix notice thrown in wp_count_comments(). Props tfnab, batmoo. fixes #15215