wptexturize with html between quotes

[westi]

There appears to be a problem with quotes in a post when used in combination with bold text followed by a comma. For example, the following:

"<strong>Quoted Text</strong>",

...will create bold quoted text but the closing quote will be backwards.

[westi]

Test cases: ​http://unit-tests.trac.wordpress.org/changeset/311

[norbertm]

Technically related to #4539.

[norbertm]

Working on a patch that resolves both.

[norbertm]

Submitted patch to #4539.

[westi]

(In [16280]) Improved RegEx for quote matching in wptexturize. Fixes #4539 and #15241 props norbertm.

[nacin]

This broke this string:

That means every moment you're working on something without it being in the public it's actually dying.

Before:

That means every moment you’re working on something without it being in the public it’s actually dying.

After:

That means every moment you‘re working on something without it being in the public it’s actually dying.

[norbertm]

That should not happen because first it would replace words with quotes in the middle and process any leftover quotes after all such occurrences were found. Looking into it.

[nacin]

New unit test

[norbertm]

Good catch, thanks. Fixed by changing the order of replacements. Also fixed the unit test which was missing some ampersands.

[westi]

Unit tests updated in ​[UT319]

[westi]

Unit tests fixed in ​[UT320]. I should read the failing tests more carefully pre-coffee ;-)

[westi]

(In [16378]) Fix regression in wptexturize with single quotes when used for contraction. See #15241 props norbertm.

[westi]

@norbertm - would you be able to spend a little bit of time fleshing out the Unit Tests with some extra tests to ensure we cover all scenarios here?

It would be good to increase the coverage on this function as it is a very fragile thing to change ;-)

[wahgnube]

The problem still exists for me, even after [16378]. e.g., I see sentences like the following on my site:

This isn&#8216;t inherently bad, but I don&#8217;t think it&#8217;s normal.

[norbertm]

@westi - definitely! I already included a bunch of tests with #4539 but there is room for more and it makes sense to clean it all up.

@wahgnube - will look into that, thanks!

[alexkingorg]

I think there is a related by different issue here #15444 however please close as a dup if that is addressed by this patch.

[nacin]

Closed #15444 as a duplicate. We should turn that into a unit test. Upping the severity based on what's in trunk.

[nacin]

(In [16409]) Revert changes to wptexturize() until test cases pass. Reverts [16280], [16378]. see #4539 and #15241.

[norbertm]

@westi - Working on more coverage.

@wahgnube - Able to reproduce. Included test case and fix in #4539.

@nacin - Added unit test to #15444. Fix in progress.

[norbertm]

Updates submitted to #4539.