WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#15242 closed enhancement (maybelater)

code cleanup for taxonomy.php

Reported by: wpmuguru Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: General Keywords: has-patch
Focuses: Cc:

Description

I was in poking around wp-includes/taxonomy.php and noticed it was lacking spacing around some of the parentheses. The first attached patch is for the first 1800 lines. I'll try to put together another patch for the rest of the file in the next week or so.

Attachments (4)

15242.diff (48.4 KB) - added by wpmuguru 5 years ago.
15242.2.diff (48.4 KB) - added by wpmuguru 5 years ago.
patch after [16056]
15242.3.diff (13.5 KB) - added by wpmuguru 5 years ago.
lines 1-900 of 15242.diff
15242.4.diff (25.4 KB) - added by wpmuguru 5 years ago.
lines 1000-1800 of 15242.diff

Download all attachments as: .zip

Change History (11)

@wpmuguru5 years ago

comment:1 @markmcwilliams5 years ago

With [16056] just gone in you'll probably need to give it a refresh Ron?

@wpmuguru5 years ago

patch after [16056]

comment:2 @wpmuguru5 years ago

skip that last patch. I'll add smaller patches.

@wpmuguru5 years ago

lines 1-900 of 15242.diff

@wpmuguru5 years ago

lines 1000-1800 of 15242.diff

comment:3 @wpmuguru5 years ago

I'll do the rest of the file after those are applied :D

comment:4 @ryan4 years ago

  • Keywords 3.2-early added
  • Milestone changed from 3.1 to Future Release

Let's do a clean up run in early 3.2.

comment:5 @scribu4 years ago

  • Keywords close added; 3.2-early removed

We shouldn't be commiting patches that are only fixing coding style.

See http://ldn.linuxfoundation.org/book/41-pitfalls

comment:6 @wpmuguru4 years ago

  • Resolution set to maybelater
  • Status changed from new to closed

comment:7 @ocean904 years ago

  • Keywords close removed
  • Milestone Future Release deleted
Note: See TracTickets for help on using tickets.