Make WordPress Core

Opened 5 years ago

Closed 2 years ago

Last modified 4 months ago

#15261 closed enhancement (fixed)

Add do_action to form tag in edit-tag-form.php

Reported by: linguasite Owned by: nacin
Milestone: 3.7 Priority: normal
Severity: normal Version: 3.1
Component: Administration Keywords: has-patch
Focuses: Cc:


How about adding additional actions to the form tags in admin taxonomy pages like edit-tag-form.php?

An example can be found in user-edit.php line 183:

<form id="your-profile" ... method="post"<?php do_action('user_edit_form_tag'); ?>>

Attachments (2)

tag_edit_form_tag_action.patch (905 bytes) - added by JustinSainton 5 years ago.
Patch for adding do_action.
15261.1.diff (1.5 KB) - added by JustinSainton 2 years ago.

Download all attachments as: .zip

Change History (15)

comment:1 @scribu5 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed
  • Type changed from feature request to enhancement

There already are plenty of hooks in wp-admin/edit-tag-form.php

comment:2 @scribu5 years ago

  • Milestone set to Awaiting Review
  • Resolution invalid deleted
  • Status changed from closed to reopened

Sorry, misread.

What is the use case for this?

comment:3 @linguasite5 years ago

With an action like this it would be possible to set the form enctype to multipart, for example. Necessary for file upload fields in the form. The only way to change the form encoding at the moment is doing it with JS.
Furthermore it could be useful to add events or a target to the form tag itself.

comment:4 @nacin5 years ago

  • Keywords needs-patch added; action edit tag removed
  • Milestone changed from Awaiting Review to Future Release

@JustinSainton5 years ago

Patch for adding do_action.

comment:5 @JustinSainton5 years ago

  • Cc JustinSainton added
  • Keywords has-patch needs-testing added; needs-patch removed

@JustinSainton2 years ago

comment:6 @JustinSainton2 years ago

Heh, refreshing the first patch I ever posted to Trac.

comment:7 @JustinSainton2 years ago

  • Keywords needs-testing removed

comment:8 @nacin2 years ago

  • Milestone changed from Future Release to 3.7

I really hate the existing actions but it's the pattern we have, so let's go with it.

comment:10 @mordauk2 years ago

  • Cc pippin@… added

comment:11 @desrosj2 years ago

Patch looks good. Works fine for me. Tested on categories, and a custom taxonomy.

comment:12 @nacin2 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from reopened to closed

In 25034:

Add actions for term editing/creation form tags, for adding enctype attributes. Matches the pattern we've used elsewhere. props JustinSainton, fixes #15261.

comment:13 @johnbillion4 months ago

#20735 was marked as a duplicate.

Note: See TracTickets for help on using tickets.