Make WordPress Core

Opened 16 years ago

Closed 13 years ago

Last modified 11 years ago

#15261 closed enhancement (fixed)

Add do_action to form tag in edit-tag-form.php

Reported by: linguasite Owned by: nacin
Priority: normal Milestone: 3.7
Component: Administration Version: 3.1
Severity: normal Keywords: has-patch
Cc: Focuses:

Description

How about adding additional actions to the form tags in admin taxonomy pages like edit-tag-form.php?

An example can be found in user-edit.php line 183:

<form id="your-profile" ... method="post"<?php do_action('user_edit_form_tag'); ?>>

Attachments (2)

tag_edit_form_tag_action.patch (905 bytes ) - added by JustinSainton 16 years ago.
Patch for adding do_action.
15261.1.diff (1.5 KB ) - added by JustinSainton 13 years ago.

Download all attachments as: .zip

Change History (15)

#1 @scribu
16 years ago

  • Milestone Awaiting Review
  • Resolutioninvalid
  • Status newclosed
  • Type feature requestenhancement

There already are plenty of hooks in wp-admin/edit-tag-form.php

#2 @scribu
16 years ago

  • MilestoneAwaiting Review
  • Resolution invalid
  • Status closedreopened

Sorry, misread.

What is the use case for this?

#3 @linguasite
16 years ago

With an action like this it would be possible to set the form enctype to multipart, for example. Necessary for file upload fields in the form. The only way to change the form encoding at the moment is doing it with JS.
Furthermore it could be useful to add events or a target to the form tag itself.

#4 @nacin
16 years ago

  • Keywords needs-patch added; action edit tag removed
  • Milestone Awaiting ReviewFuture Release

@JustinSainton
16 years ago

Patch for adding do_action.

#5 @JustinSainton
16 years ago

  • Cc JustinSainton added
  • Keywords has-patch needs-testing added; needs-patch removed

#6 @JustinSainton
13 years ago

Heh, refreshing the first patch I ever posted to Trac.

#7 @JustinSainton
13 years ago

  • Keywords needs-testing removed

#8 @nacin
13 years ago

  • Milestone Future Release3.7

I really hate the existing actions but it's the pattern we have, so let's go with it.

#10 @mordauk
13 years ago

  • Cc pippin@… added

#11 @desrosj
13 years ago

Patch looks good. Works fine for me. Tested on categories, and a custom taxonomy.

#12 @nacin
13 years ago

  • Owner set to nacin
  • Resolutionfixed
  • Status reopenedclosed

In 25034:

Add actions for term editing/creation form tags, for adding enctype attributes. Matches the pattern we've used elsewhere. props JustinSainton, fixes #15261.

#13 @johnbillion
11 years ago

#20735 was marked as a duplicate.

Note: See TracTickets for help on using tickets.