WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 21 months ago

#15261 closed enhancement (fixed)

Add do_action to form tag in edit-tag-form.php

Reported by: linguasite Owned by: nacin
Milestone: 3.7 Priority: normal
Severity: normal Version: 3.1
Component: Administration Keywords: has-patch
Focuses: Cc:

Description

How about adding additional actions to the form tags in admin taxonomy pages like edit-tag-form.php?

An example can be found in user-edit.php line 183:

<form id="your-profile" ... method="post"<?php do_action('user_edit_form_tag'); ?>>

Attachments (2)

tag_edit_form_tag_action.patch (905 bytes) - added by JustinSainton 4 years ago.
Patch for adding do_action.
15261.1.diff (1.5 KB) - added by JustinSainton 21 months ago.

Download all attachments as: .zip

Change History (14)

comment:1 @scribu4 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed
  • Type changed from feature request to enhancement

There already are plenty of hooks in wp-admin/edit-tag-form.php

comment:2 @scribu4 years ago

  • Milestone set to Awaiting Review
  • Resolution invalid deleted
  • Status changed from closed to reopened

Sorry, misread.

What is the use case for this?

comment:3 @linguasite4 years ago

With an action like this it would be possible to set the form enctype to multipart, for example. Necessary for file upload fields in the form. The only way to change the form encoding at the moment is doing it with JS.
Furthermore it could be useful to add events or a target to the form tag itself.

comment:4 @nacin4 years ago

  • Keywords needs-patch added; action edit tag removed
  • Milestone changed from Awaiting Review to Future Release

@JustinSainton4 years ago

Patch for adding do_action.

comment:5 @JustinSainton4 years ago

  • Cc JustinSainton added
  • Keywords has-patch needs-testing added; needs-patch removed

@JustinSainton21 months ago

comment:6 @JustinSainton21 months ago

Heh, refreshing the first patch I ever posted to Trac.

comment:7 @JustinSainton21 months ago

  • Keywords needs-testing removed

comment:8 @nacin21 months ago

  • Milestone changed from Future Release to 3.7

I really hate the existing actions but it's the pattern we have, so let's go with it.

comment:10 @mordauk21 months ago

  • Cc pippin@… added

comment:11 @desrosj21 months ago

Patch looks good. Works fine for me. Tested on categories, and a custom taxonomy.

comment:12 @nacin21 months ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from reopened to closed

In 25034:

Add actions for term editing/creation form tags, for adding enctype attributes. Matches the pattern we've used elsewhere. props JustinSainton, fixes #15261.

Note: See TracTickets for help on using tickets.