WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 4 years ago

#15262 closed defect (bug) (fixed)

Make Easter Egg GPL Compliant

Reported by: filosofo Owned by: filosofo
Milestone: 3.1 Priority: normal
Severity: normal Version: 3.1
Component: General Keywords: has-patch
Focuses: Cc:

Description

The easter egg is funny; it has soul; I'm not complaining about it per se.

However, to be compliant with the GPL 2, we must distribute the WordPress "source code," which is

the preferred form of the work for making modifications to it.

It should be obvious that obfuscated code is not "the preferred form of the work for making modifications to it," and in fact the FSF says explicitly

Obfuscated “source code” is not real source code and does not count as source code."

The attached patch provides an un-obfuscated version of the easter egg code, to bring the code into compliance with the GPL.

Attachments (2)

un-obfuscated-easter-egg.15262.diff (3.8 KB) - added by filosofo 6 years ago.
revisions-js-dev.php (3.4 KB) - added by nacin 6 years ago.

Download all attachments as: .zip

Change History (13)

#1 @Denis-de-Bernardy
6 years ago

Thiis is unobfuscated? :-D

#2 @filosofo
6 years ago

Everything is either un-obscured or explained in a comment.

#3 follow-up: @caesarsgrunt
6 years ago

What is the easter egg anyway?

#4 in reply to: ↑ 3 @Denis-de-Bernardy
6 years ago

Replying to caesarsgrunt:

What is the easter egg anyway?

I take it you never had a customer wake you up in the middle of the night because his site got hacked... Try comparing a revision to itself to see what it looks like.

#5 @caesarsgrunt
6 years ago

Hehe... never came across that! I'm glad to see someone with commit access has a sense of humour. :-D

#6 @hakre
6 years ago

I'm pretty sure the easter egg works very well w/o dvortr. So the patch could be improved to have the text as plain so it's easier to be edited, IMHO "the preferred form of the work for making modifications to it" and this would not destroy the joke at all.

#7 @markjaquith
6 years ago

We don't have to distribute it with WordPress. What if the obfuscated version just linked to the non-obfuscated version? That should satisfy the requirement.

#8 @filosofo
6 years ago

Yes, I think that would meet the requirements of the GPL.

If we put that at, e.g., a wordpress.org FTP resource, we could add the source for the obscured JS and compiled Flash in some of the third-party code we're using. Though not required, having those third-party sources would keep everything in place and ensure that they are still available even if the originals disappear.

#9 @ryan
6 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [16826]) Link to unobfuscated JS. Props filosofo. fixes #15262

#10 @hakre
4 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

I'd say this should be put here: http://code.trac.wordpress.org/browser/wordpress-sources

Not linked. This repo maybe came later so this was not originally suggested.

Tag: FIXIPO

X-Ref: #24852

Last edited 4 years ago by hakre (previous) (diff)

#11 @markoheijnen
4 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

This should be discussed on #24852 and not in an ticket that has been fixed on a previous milestone.

Note: See TracTickets for help on using tickets.