WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#15269 closed defect (bug) (fixed)

Screen options are not saving on the Network Admin themes/plugins

Reported by: PeteMall Owned by: ocean90
Milestone: 3.1 Priority: normal
Severity: normal Version: 3.1
Component: Multisite Keywords: has-patch
Focuses: Cc:

Description

Screen options for the network admin themes and plugins administration panel are not updated.

Attachments (5)

15269.patch (2.1 KB) - added by ocean90 3 years ago.
Use the default default value and save the options
15269.2.patch (3.5 KB) - added by ocean90 3 years ago.
15269.3.patch (3.6 KB) - added by ocean90 3 years ago.
15269.4.patch (4.5 KB) - added by ocean90 3 years ago.
Here we go.
15269.5.patch (9.0 KB) - added by ocean90 3 years ago.

Download all attachments as: .zip

Change History (14)

comment:1 scribu3 years ago

  • Milestone changed from Awaiting Review to 3.1

ocean903 years ago

Use the default default value and save the options

comment:2 ocean903 years ago

Option can be saved with the page, but the navigation for the per_page option is missing. Should be there a per_page option?

ocean903 years ago

comment:3 ocean903 years ago

  • Keywords has-patch added; needs-patch removed

Network themes/plugins works with the patch.

comment:4 scribu3 years ago

  • Keywords needs-patch added; has-patch removed

15269.2.patch prevents ajaxed pagination from working:

Notice: Undefined property: stdClass::$id in /wp/wp-admin/includes/class-wp-list-table-plugins.php on line 132

ocean903 years ago

comment:5 ocean903 years ago

  • Keywords has-patch added; needs-patch removed
  • Owner set to ocean90
  • Status changed from new to accepted

comment:6 scribu3 years ago

It seems it's ignoring the setting when trying to go to the second page via AJAX.

comment:7 scribu3 years ago

is_network_admin() returns false on AJAX requests.

ocean903 years ago

Here we go.

ocean903 years ago

comment:9 scribu3 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

(In [16194]) Fix screen options for the network admin themes and plugins. Props ocean90. Fixes #15269. Also fixes [16190]

Note: See TracTickets for help on using tickets.